Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-cluster-shared-leak #4510

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-cluster-shared-leak #4510

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 1, 2016

Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: #3956

@Trott Trott added cluster Issues and PRs related to the cluster subsystem. windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Jan 1, 2016
This was referenced Jan 1, 2016
Closed
Closed
@Trott
test: fix flaky test-cluster-shared-leak
7b2c64b 
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
@Trott
Copy link
Member Author

Trott commented Jan 3, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1131/

All green! \o/

@Trott
Copy link
Member Author

Trott commented Jan 3, 2016

Confirmed that the test still triggers an AssertionError in Node 4.2.1, so it still tests what it was originally written to test.

@Trott
Copy link
Member Author

Trott commented Jan 3, 2016

Stress tests:

With this fix, 9999 runs and no errors: https://ci.nodejs.org/job/node-stress-single-test/288/nodes=win2012r2-1p/console

Without, 9999 runs and four errors: https://ci.nodejs.org/job/node-stress-single-test/289/nodes=win2012r2-1p/console

@jbergstroem
Copy link
Member

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Jan 4, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jan 4, 2016
@Trott
test: fix flaky test-cluster-shared-leak
063c9f6 
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 4, 2016

Landed in 063c9f6

@Trott Trott closed this Jan 4, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
@Trott @Fishrock123
test: fix flaky test-cluster-shared-leak
984db93 
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
@mscdex
Copy link
Contributor

mscdex commented Jan 8, 2016

@Trott It looks like this is happening still, at least on win10 now: https://ci.nodejs.org/job/node-test-binary-windows/506/RUN_SUBSET=0,VS_VERSION=vs2015,label=win10/console

@Trott
Copy link
Member Author

Trott commented Jan 8, 2016

@mscdex Unfortunately, yes. And unfortunately, I can't seem to replicate the failure in the stress test. Which is kind of troubling. Anyway, see #4476 (comment) and #4476 (comment)

@MylesBorins
Copy link
Contributor

@Trott this one needs to be manually backported too :(

@Trott
Copy link
Member Author

Trott commented Jan 15, 2016

@thealphanerd This will apply cleanly if you land #4421 first.

MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
@Trott
test: fix flaky test-cluster-shared-leak
927bacb 
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: #3956
PR-URL: #4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
@Trott
test: fix flaky test-cluster-shared-leak
eeac12e 
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: #3956
PR-URL: #4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
@Trott
test: fix flaky test-cluster-shared-leak
ab91e12 
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
@Trott
test: fix flaky test-cluster-shared-leak
ec24d37 
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: fix flaky test-cluster-shared-leak
cf3c3bf 
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
@Trott Trott deleted the fix-epipe-win branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jbergstroem @jasnell @mscdex @MylesBorins