test: remove a snapshot blob from test-inspect-address-in-use.js #45132

daeyeon · 2022-10-23T10:46:03Z

This removes a snapshot blob generated by test/parallel/test-inspect-address-in-use.js.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

This removes a snapshot blob generated by `test/parallel/test-inspect-address-in-use.js`. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

nodejs-github-bot · 2022-10-24T01:23:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47433/

legendecas · 2022-10-24T06:37:17Z

This PR fixes #45017.

nodejs-github-bot · 2022-10-24T18:17:07Z

Commit Queue failed

- Loading data for nodejs/node/pull/45132
✔  Done loading data for nodejs/node/pull/45132
----------------------------------- PR info ------------------------------------
Title      test: remove a snapshot blob from test-inspect-address-in-use.js (#45132)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     daeyeon:main.test-rm-snapshot-blob-221023.Sun.c7b0 -> nodejs:main
Labels     test, author ready, needs-ci
Commits    1
 - test: remove a snapshot blob from test-inspect-address-in-use.js
Committers 1
 - Daeyeon Jeong 
PR-URL: https://github.com/nodejs/node/pull/45132
Fixes: https://github.com/nodejs/node/issues/45017
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Juan José Arboleda 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45132
Fixes: https://github.com/nodejs/node/issues/45017
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Juan José Arboleda 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 23 Oct 2022 10:46:03 GMT
   ✔  Approvals: 8
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152309779
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152316298
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152347016
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152356292
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152593873
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152595593
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152595610
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/45132#pullrequestreview-1153559652
   ✖  This PR needs to wait 16 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-24T01:23:42Z: https://ci.nodejs.org/job/node-test-pull-request/47433/
- Querying data for job/node-test-pull-request/47433/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3315101734

github-actions · 2022-10-25T03:36:18Z

Fast-track has been requested by @Trott. Please 👍 to approve.

nodejs-github-bot · 2022-10-25T15:12:50Z

Commit Queue failed

- Loading data for nodejs/node/pull/45132
✔  Done loading data for nodejs/node/pull/45132
----------------------------------- PR info ------------------------------------
Title      test: remove a snapshot blob from test-inspect-address-in-use.js (#45132)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     daeyeon:main.test-rm-snapshot-blob-221023.Sun.c7b0 -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: remove a snapshot blob from test-inspect-address-in-use.js
Committers 1
 - Daeyeon Jeong 
PR-URL: https://github.com/nodejs/node/pull/45132
Fixes: https://github.com/nodejs/node/issues/45017
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Juan José Arboleda 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45132
Fixes: https://github.com/nodejs/node/issues/45017
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Juan José Arboleda 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 23 Oct 2022 10:46:03 GMT
   ✔  Approvals: 8
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152309779
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152316298
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152347016
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152356292
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152593873
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152595593
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/45132#pullrequestreview-1152595610
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/45132#pullrequestreview-1153559652
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-24T18:17:07Z: https://ci.nodejs.org/job/node-test-pull-request/47433/
- Querying data for job/node-test-pull-request/47433/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3322095441

nodejs-github-bot · 2022-10-26T00:35:30Z

Landed in 0a7ba84

This removes a snapshot blob generated by `test/parallel/test-inspect-address-in-use.js`. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45132 Fixes: #45017 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

test: remove a snapshot blob from test-inspect-address-in-use.js

1235f84

This removes a snapshot blob generated by `test/parallel/test-inspect-address-in-use.js`. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 23, 2022

cjihrig approved these changes Oct 23, 2022

View reviewed changes

Trott approved these changes Oct 23, 2022

View reviewed changes

Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 23, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2022

This comment was marked as outdated.

Sign in to view

Trott mentioned this pull request Oct 23, 2022

test: avoid generating snapshot blobs outside tmpdir #45137

Closed

This comment was marked as outdated.

Sign in to view

lpinca approved these changes Oct 23, 2022

View reviewed changes

joyeecheung approved these changes Oct 23, 2022

View reviewed changes

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Oct 24, 2022

CI Reliability 2022-10-24 nodejs/reliability#409

Open

13 tasks

legendecas approved these changes Oct 24, 2022

View reviewed changes

jasnell approved these changes Oct 24, 2022

View reviewed changes

targos approved these changes Oct 24, 2022

View reviewed changes

juanarbol approved these changes Oct 24, 2022

View reviewed changes

juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 24, 2022

github-actions bot mentioned this pull request Oct 25, 2022

CI Reliability 2022-10-25 nodejs/reliability#410

Open

16 tasks

Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 25, 2022

daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 25, 2022

github-actions bot mentioned this pull request Oct 26, 2022

CI Reliability 2022-10-26 nodejs/reliability#411

Open

14 tasks

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 26, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022

nodejs-github-bot merged commit 0a7ba84 into nodejs:main Oct 26, 2022

daeyeon deleted the main.test-rm-snapshot-blob-221023.Sun.c7b0 branch October 26, 2022 00:56

This was referenced Oct 27, 2022

CI Reliability 2022-10-27 nodejs/reliability#412

Open

CI Reliability 2022-10-28 nodejs/reliability#413

Open

RafaelGSS mentioned this pull request Nov 1, 2022

v19.1.0 proposal #45269

Merged

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: remove a snapshot blob from test-inspect-address-in-use.js #45132

test: remove a snapshot blob from test-inspect-address-in-use.js #45132

daeyeon commented Oct 23, 2022 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Oct 24, 2022

legendecas commented Oct 24, 2022

nodejs-github-bot commented Oct 24, 2022

github-actions bot commented Oct 25, 2022

nodejs-github-bot commented Oct 25, 2022

nodejs-github-bot commented Oct 26, 2022

test: remove a snapshot blob from test-inspect-address-in-use.js #45132

test: remove a snapshot blob from test-inspect-address-in-use.js #45132

Conversation

daeyeon commented Oct 23, 2022 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Oct 24, 2022

legendecas commented Oct 24, 2022

nodejs-github-bot commented Oct 24, 2022

github-actions bot commented Oct 25, 2022

nodejs-github-bot commented Oct 25, 2022

nodejs-github-bot commented Oct 26, 2022

daeyeon commented Oct 23, 2022 •

edited

Loading