Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-http-agent-keepalive #4524

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 4, 2016

Remove timeout delay causing flakiness on SmartOS.

The key change is the setTimeout->setImmediate in line 21. The rest of the changes are just opportunistic updates.

Fixes: #4492

Remove timeout delay causing flakiness on SmartOS.

Fixes: nodejs#4492
@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. smartos Issues and PRs related to the SmartOS platform. labels Jan 4, 2016
@jbergstroem
Copy link
Member

@rvagg
Copy link
Member

rvagg commented Jan 4, 2016

nice nice, this reminds me of webdev where you throw random delays at stuff to fix them!

lgtm, great work as usual @Trott.

@Trott
Copy link
Member Author

Trott commented Jan 4, 2016

CI: https://ci.nodejs.org/job/node-test-commit/1616/

Stress test without this fix: 14 failures in 9999 runs

Stress test with this fix: 0 failures in 2139 runs so far and counting...

@jbergstroem
Copy link
Member

Make that + echo '3826 OK: 3826 NOT OK: 0' 4k+ tests, none failed. LGTM.

@jasnell
Copy link
Member

jasnell commented Jan 4, 2016

LGTM

Trott added a commit that referenced this pull request Jan 4, 2016
Remove timeout delay causing flakiness on SmartOS.

Fixes: #4492
PR-URL: #4524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@jasnell
Copy link
Member

jasnell commented Jan 4, 2016

Landed in 6ea8b01

@jasnell jasnell closed this Jan 4, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
Remove timeout delay causing flakiness on SmartOS.

Fixes: nodejs#4492
PR-URL: nodejs#4524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
Remove timeout delay causing flakiness on SmartOS.

Fixes: #4492
PR-URL: #4524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
Remove timeout delay causing flakiness on SmartOS.

Fixes: #4492
PR-URL: #4524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Remove timeout delay causing flakiness on SmartOS.

Fixes: #4492
PR-URL: #4524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Remove timeout delay causing flakiness on SmartOS.

Fixes: nodejs#4492
PR-URL: nodejs#4524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott Trott deleted the deflake-http-agent-keepalive branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants