[DRAFT] lib: fix structuredclone error for process.env #45384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJithil
force-pushed
the
fix-45380-structuredClone-issues
branch
from
2bf611c to
c782803
Compare
MrJithil
force-pushed
the
fix-45380-structuredClone-issues
branch
from
c782803 to
c173165
Compare
|
this pr will cause some valid cases to return the wrong values: arrays, strings, etc |
MrJithil
changed the title
MrJithil
force-pushed
the
fix-45380-structuredClone-issues
branch
from
c173165 to
145b0a0
Compare
lib: fix structuredclone error for process.env
MrJithil
force-pushed
the
fix-45380-structuredClone-issues
branch
from
145b0a0 to
eeabc9c
Compare
targos
reviewed
Nov 9, 2022
| @@ -20,6 +21,8 @@ function structuredClone(value, options = undefined) { | |||
| channel ??= new MessageChannel(); | |||
| channel.port1.unref(); | |||
| channel.port2.unref(); | |||
| if (typeof value === 'object' && !ArrayIsArray(value)) | |||
| value = { ...value }; | |||
There was a problem hiding this comment.
This won't work for special objects that are transferable, such as error objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal: fix structuredclone error for process.env
fixes #45380