-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix actual result of example is different in events #45656
doc: fix actual result of example is different in events #45656
Conversation
Just ran with the below code example (separately, we should probably update this specific code example to actually be runnable with the below code) and got the updated output. const EventEmitter = require('node:events');
class MyEmitter extends EventEmitter {};
const myEmitter = new MyEmitter();
myEmitter.on('event', function(a, b) {
console.log(a, b, this, this === myEmitter);
});
myEmitter.emit('event', 'a', 'b'); |
Nit: the commit message title needs to start with an imperative verb to meet the guideline below. This isn't a blocker since it could be fixed by someone when landing the PR. However, it can be fixed also by a force push. node/doc/contributing/pull-requests.md Lines 168 to 171 in a1c62cf
|
Change of events internal may be not reflected yet.
1ed643b
to
56f9768
Compare
@daeyeon Thank you for kind explanation and remind. Updated commit message title starting with an imperative verb. |
Landed in ab064d1 |
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet.
In document, result of example is like below.
But actual result of example with current node is like below.