test: move test file to sequential/ due to timing issues #45722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Trott
added
the
commit-queue-squash
|
Closes: #43465 |
|
@nodejs/http @nodejs/testing |
Trott
approved these changes
Dec 3, 2022
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
This was referenced Aug 21, 2023
aduh95
force-pushed
the
move_test_to_run_sequentially
branch
from
6ae29c5 to
07fcb59
Compare
aduh95
added
the
author ready
|
Landed in b41ab9d |
Merged
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#45722 Fixes: nodejs#43465 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#45722 Fixes: nodejs#43465 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving test-http-server-request-timeouts-mixed from tests/parallel to tests/sequential
The flaky test is reproducible when we run
tools/test.py -j96 --repeat=1024 test/parallel/test-http-server-request-timeouts-mixed.js. I tried tuning the timeouts at which the values are asserted, but they still seem to fail because of timing issues when the system is burdened.As a workaround, I have moved the test to run sequentially(verified it with
tools/test.py -j96 --repeat=128 test/sequential/test-http-server-request-timeouts-mixed.js)Fixes: #43465