Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: refactor to use a method that formats a list string #45793

Merged
merged 5 commits into from
Dec 23, 2022
Merged

errors: refactor to use a method that formats a list string #45793

merged 5 commits into from
Dec 23, 2022

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Dec 9, 2022

This introduces a function that creates a list string for places requiring it.

Also includes a fix for the error message of ERR_UNSUPPORTED_ESM_URL_SCHEME.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

@daeyeon
errors: refactor to use a method that formats a list string
698c378 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@daeyeon
errors: fix ERR_UNSUPPORTED_ESM_URL_SCHEME error message
657e660 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Dec 9, 2022
@daeyeon daeyeon added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 9, 2022
aduh95
aduh95 reviewed Dec 9, 2022
View reviewed changes
lib/internal/errors.js Show resolved Hide resolved
test/parallel/test-error-format-list.js Outdated Show resolved Hide resolved
@daeyeon
Copy link
Member Author

daeyeon commented Dec 9, 2022

Updated the PR to reflect the suggestions. Thanks.

daeyeon and others added 2 commits December 9, 2022 19:15
@daeyeon @aduh95
fixup! errors: fix ERR_UNSUPPORTED_ESM_URL_SCHEME error message
9a04ac1 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@daeyeon @aduh95
fixup! fixup! errors: fix ERR_UNSUPPORTED_ESM_URL_SCHEME error message
d513efb 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@daeyeon daeyeon force-pushed the 221209.Fri.69f3.main.simplify-format-list branch from 8d580aa to d513efb Compare December 9, 2022 10:18
aduh95
aduh95 reviewed Dec 9, 2022
View reviewed changes
lib/internal/errors.js Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Dec 9, 2022
View reviewed changes
lib/internal/errors.js Outdated Show resolved Hide resolved
@daeyeon @aduh95
fixup! fixup! fixup! errors: fix ERR_UNSUPPORTED_ESM_URL_SCHEME error…
a05a23a 
… message

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@daeyeon
Copy link
Member Author

daeyeon commented Dec 12, 2022

Changed according to code review. PTAL. @aduh95

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48602/

This was referenced Dec 20, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48688/

@github-actions github-actions bot mentioned this pull request Dec 22, 2022
Open
14 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48691/

@github-actions github-actions bot mentioned this pull request Dec 23, 2022
Open
13 tasks
@daeyeon daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2022
@nodejs-github-bot nodejs-github-bot merged commit 28fe494 into nodejs:main Dec 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 28fe494

@daeyeon daeyeon deleted the 221209.Fri.69f3.main.simplify-format-list branch December 23, 2022 01:26
This was referenced Dec 24, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 31, 2022
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@daeyeon @targos
errors: refactor to use a method that formats a list string
661ed24 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45793
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>