Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the word 'Class' before incomingmessage in http docs #4589

Closed
wants to merge 1 commit into from
Closed

add the word 'Class' before incomingmessage in http docs #4589

wants to merge 1 commit into from

Conversation

Sequoia
Copy link
Contributor

@Sequoia Sequoia commented Jan 8, 2016

Closes #4576

@jasnell
Copy link
Member

jasnell commented Jan 8, 2016

LGTM

@jasnell jasnell added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Jan 8, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jan 8, 2016

LGTM, but the commit message should be updated per https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit

@Sequoia
doc: label http.IncomingMessage as a "Class"
e328b21 
`Server`, `ServerResponse` etc. were marked as
classes, this one class was overlooked.
@Sequoia Sequoia force-pushed the add-class-to-incomingmessage branch from a5c8051 to e328b21 Compare January 8, 2016 18:47
@Sequoia
Copy link
Contributor Author

Sequoia commented Jan 8, 2016

updated to add subsystem & check line length

@ryansobol
Copy link
Contributor

LGTM, although I'm not sure the backticks in the commit message are necessary

silverwind pushed a commit that referenced this pull request Jan 11, 2016
@Sequoia @silverwind
doc: label http.IncomingMessage as a Class
b40aca1 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

LGTM, landed in b40aca1.

And yeah, we don't usually do backticks in commit messages, no specific reason. I left them out 😉

@silverwind silverwind closed this Jan 11, 2016
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
6f2e28a 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Jan 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
fdfc72c 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
367a13d 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
f2fa2d3 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
70791ae 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@rvagg
Copy link
Member

rvagg commented Jan 18, 2016

First commit to core for you @Sequoia, as far as I can tell. A small one but even minor doc fixes are always appreciated. Thanks!

@Sequoia
Copy link
Contributor Author

Sequoia commented Jan 18, 2016

@rvagg the pleasure is all mine! 😸

MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
bd31740 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
ac96253 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: nodejs#4589
Fixes: nodejs#4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Sequoia @jasnell @cjihrig @ryansobol @silverwind @rvagg @MylesBorins