[18.x] src: clarify OptionEnvvarSettings member names #45994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
legendecas
changed the title
nodejs-github-bot
added
c++
danielleadams
force-pushed
the
v18.x-staging
branch
2 times, most recently
from
2098d7a
to
bac6b7d
Compare
fhinkel
approved these changes
Jan 25, 2023
juanarbol
force-pushed
the
v18.x-staging
branch
from
7351221
to
fcfde34
Compare
|
Has this any chance of landing? Would be great to get the Happy Eyeballs global setting in 18.x working asap. |
|
@legendecas are you able to rebase this to get it landed? |
The term `Environment` in `kAllowedInEnvironment` and `kDisallowedInEnvironment` has nothing to do with the commonly used term `node::Environment`. Rename the member to `kAllowedInEnvvar` and `kDisallowedInEnvvar` respectively to reflect they are options of `OptionEnvvarSettings`. As `OptionEnvvarSettings` is part of the public embedder APIs, the legacy names are still preserved. PR-URL: nodejs#45057 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
legendecas
force-pushed
the
backport-45057-to-18
branch
from
0585746
to
37d7f81
Compare
|
Rebased. |
github-actions
bot
removed
the
request-ci
This was referenced May 24, 2023
|
Flaky tests or CI problem? |
This was referenced May 28, 2023
danielleadams
approved these changes
May 29, 2023
|
Landed in 0d5e324 |
danielleadams
pushed a commit
that referenced
this pull request
May 29, 2023
The term `Environment` in `kAllowedInEnvironment` and `kDisallowedInEnvironment` has nothing to do with the commonly used term `node::Environment`. Rename the member to `kAllowedInEnvvar` and `kDisallowedInEnvvar` respectively to reflect they are options of `OptionEnvvarSettings`. As `OptionEnvvarSettings` is part of the public embedder APIs, the legacy names are still preserved. PR-URL: #45057 Backport-PR-URL: #45994 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
23 tasks
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term
EnvironmentinkAllowedInEnvironmentandkDisallowedInEnvironmenthas nothing to do with the commonly used termnode::Environment. Rename the member tokAllowedInEnvvarandkDisallowedInEnvvarrespectively to reflect they are options ofOptionEnvvarSettings.As
OptionEnvvarSettingsis part of the public embedder APIs, the legacy names are still preserved.PR-URL: #45057
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net