Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: remove assert.snapshot #46112

Merged
merged 1 commit into from
Jan 7, 2023
Merged

assert: remove assert.snapshot #46112

merged 1 commit into from
Jan 7, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jan 5, 2023

following the discussion in #44466 (comment)
removing assert.snapshot and will add another implementation to node:test

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 5, 2023
@MoLow MoLow added the assert Issues and PRs related to the assert subsystem. label Jan 5, 2023
ljharb
ljharb approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per #44095 (review), i don’t think this is a feature that even belongs in a well-tested codebase, let alone in node core, at least until all the quirks are figured out in the ecosystem.

@GeoffreyBooth GeoffreyBooth added the test_runner Issues and PRs related to the test runner subsystem. label Jan 5, 2023
@cjihrig
Copy link
Contributor

cjihrig commented Jan 5, 2023

removing assert.snapshot and will add another implementation to node:test

I'm curious why this would belong in node:test. I think node:assert is the correct place for this functionality - the API just needs some rework IMO.

@cjihrig cjihrig removed the test_runner Issues and PRs related to the test runner subsystem. label Jan 5, 2023
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48878/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit 11e7858 into nodejs:main Jan 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 11e7858

@MoLow MoLow deleted the remove-assert-snapshot branch January 7, 2023 20:52
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@MoLow @RafaelGSS
assert: remove assert.snapshot
65b88b3 
PR-URL: nodejs#46112
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@MoLow @RafaelGSS
assert: remove assert.snapshot
def3694 
PR-URL: #46112
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@MoLow @juanarbol
assert: remove assert.snapshot
0c074dc 
PR-URL: #46112
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@MoLow @juanarbol
assert: remove assert.snapshot
1352f08 
PR-URL: #46112
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Josh-Walker-GM Josh-Walker-GM mentioned this pull request Apr 28, 2023
Closed
@simoneb simoneb mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MoLow @nodejs-github-bot @cjihrig @ljharb @GeoffreyBooth @lpinca @tniessen @aduh95