Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: duplex and readable from uncaught exception #46135

Merged
merged 4 commits into from
Jan 11, 2023
Merged

doc: duplex and readable from uncaught exception #46135

merged 4 commits into from
Jan 11, 2023

Conversation

marco-ippolito
Copy link
Member

resolves: #46071
Warning the user that using Duplex.from or Readable.from passing an iterable with promises as argument, could lead to uncaught exceptions

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jan 8, 2023
@marco-ippolito marco-ippolito changed the title doc: duplex and readable from uncaught exeception warning doc: duplex and readable from uncaught exception warning Jan 8, 2023
@marco-ippolito marco-ippolito changed the title doc: duplex and readable from uncaught exception warning doc: duplex and readable from uncaught exception Jan 8, 2023
Trott
Trott reviewed Jan 8, 2023
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 8, 2023
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 8, 2023
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 8, 2023
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@marco-ippolito marco-ippolito requested a review from Trott January 8, 2023 17:56
@Trott
Copy link
Member

Trott commented Jan 8, 2023

@nodejs/streams @nodejs/documentation

mcollina
mcollina reviewed Jan 8, 2023
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2023
ShogunPanda
ShogunPanda approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48911/

@mcollina
Copy link
Member

It's unhandled rejection, not uncaught rejections.

mcollina
mcollina approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPanda ShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 611d5b4 into nodejs:main Jan 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 611d5b4

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@marco-ippolito @RafaelGSS
doc: duplex and readable from uncaught execption warning
435061e 
PR-URL: nodejs#46135
Fixes: nodejs#46071
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@marco-ippolito @RafaelGSS
doc: duplex and readable from uncaught execption warning
eef7489 
PR-URL: #46135
Fixes: #46071
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@marco-ippolito @juanarbol
doc: duplex and readable from uncaught execption warning
91f5625 
PR-URL: #46135
Fixes: #46071
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@marco-ippolito @juanarbol
doc: duplex and readable from uncaught execption warning
d0f905b 
PR-URL: #46135
Fixes: #46071
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymen94 aymen94 aymen94 approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@mcollina mcollina mcollina approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stream.Duplex.from with rejecting promise leads to uncaught exception
6 participants
@marco-ippolito @Trott @nodejs-github-bot @mcollina @ShogunPanda @aymen94