-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add automation for updating postject dependency #46157
Merged
nodejs-github-bot
merged 3 commits into
nodejs:main
from
RaisinTen:setup-updating-system-for-postject
Jan 14, 2023
Merged
tools: add automation for updating postject dependency #46157
nodejs-github-bot
merged 3 commits into
nodejs:main
from
RaisinTen:setup-updating-system-for-postject
Jan 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Review requested:
|
nodejs-github-bot
added
meta
Issues and PRs related to the general management of the project.
tools
Issues and PRs related to the tools directory.
labels
Jan 10, 2023
tony-go
reviewed
Jan 10, 2023
tony-go
approved these changes
Jan 10, 2023
aduh95
reviewed
Jan 10, 2023
aduh95
reviewed
Jan 10, 2023
Refs: nodejs#46157 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
Refs: nodejs#46157 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
added
the
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
label
Jan 11, 2023
aduh95
approved these changes
Jan 12, 2023
RaisinTen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 12, 2023
aymen94
approved these changes
Jan 13, 2023
mhdawson
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@facutuesca if you have a change to review as well that would be good. |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 13, 2023
This comment was marked as outdated.
This comment was marked as outdated.
19 tasks
RaisinTen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 14, 2023
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jan 14, 2023
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
removed
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Jan 14, 2023
RaisinTen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 14, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 14, 2023
Landed in d7d9811 |
This was referenced Jan 15, 2023
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#46157 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Jan 18, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46157 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46157 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46157 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
RaisinTen
added
the
single-executable
Issues and PRs related to single-executable applications
label
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
meta
Issues and PRs related to the general management of the project.
single-executable
Issues and PRs related to single-executable applications
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @nodejs/single-executable