events: change status of event.returnvalue to legacy
#46175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`event.returnvalue` is described as legacy in spec. Plus, add missed '#'(private member) of defaultPrevented in implementation. Refs: https://dom.spec.whatwg.org/#interface-event Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue
jasnell
approved these changes
Jan 13, 2023
aduh95
reviewed
Jan 16, 2023
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
reviewed
Jan 17, 2023
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Jan 17, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46175 ✔ Done loading data for nodejs/node/pull/46175 ----------------------------------- PR info ------------------------------------ Title events: change status of `event.returnvalue` to legacy (#46175) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:230112_event_returnvalue_legacy -> nodejs:main Labels author ready, needs-ci Commits 3 - events: change status of `event.returnvalue` to legacy - use cancelable to determine returnValue - revise description of `event.returnValue` Committers 2 - Deokjin Kim - GitHub PR-URL: https://github.com/nodejs/node/pull/46175 Refs: https://dom.spec.whatwg.org/#interface-event Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46175 Refs: https://dom.spec.whatwg.org/#interface-event Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 11 Jan 2023 23:52:53 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46175#pullrequestreview-1247085422 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46175#pullrequestreview-1251339886 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-01-17T14:45:15Z: https://ci.nodejs.org/job/node-test-pull-request/49010/ - Querying data for job/node-test-pull-request/49010/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 46175 From https://github.com/nodejs/node * branch refs/pull/46175/merge -> FETCH_HEAD ✔ Fetched commits as cf8c6994e0f7..e8262f69afbd -------------------------------------------------------------------------------- Auto-merging doc/api/events.md [main e10a37f04f] events: change status of `event.returnvalue` to legacy Author: Deokjin Kim Date: Thu Jan 12 08:46:33 2023 +0900 2 files changed, 5 insertions(+), 1 deletion(-) [main 238bd86f97] use cancelable to determine returnValue Author: Deokjin Kim Date: Tue Jan 17 12:21:14 2023 +0900 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging doc/api/events.md [main 6c25c19cd3] revise description of `event.returnValue` Author: Deokjin Kim Date: Tue Jan 17 19:05:36 2023 +0900 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/3954156853 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 65f8a27 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
`event.returnvalue` is described as legacy in spec. Plus, add missed '#'(private member) of defaultPrevented in implementation. Refs: https://dom.spec.whatwg.org/#interface-event Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue PR-URL: #46175 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
`event.returnvalue` is described as legacy in spec. Plus, add missed '#'(private member) of defaultPrevented in implementation. Refs: https://dom.spec.whatwg.org/#interface-event Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue PR-URL: #46175 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
`event.returnvalue` is described as legacy in spec. Plus, add missed '#'(private member) of defaultPrevented in implementation. Refs: https://dom.spec.whatwg.org/#interface-event Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue PR-URL: #46175 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event.returnvalueis described as legacy in spec. Plus, add missed '#'(private member) of defaultPrevented in implementation.Refs: https://dom.spec.whatwg.org/#interface-event
Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue