Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use "file system" instead of "filesystem" #46178

Merged
merged 1 commit into from
Jan 14, 2023
Merged

doc: use "file system" instead of "filesystem" #46178

merged 1 commit into from
Jan 14, 2023

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 12, 2023

#44004 (comment)

Lint rule to follow.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 12, 2023
Trott added a commit to Trott/remark-preset-lint-node that referenced this pull request Jan 12, 2023
@Trott
feat: add linting for "file system" vs. "filesystem"
b272803 
Ref: nodejs/node#46178
@Trott Trott mentioned this pull request Jan 12, 2023
Merged
mcollina
mcollina approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 12, 2023
bnoordhuis
bnoordhuis approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't proper MS style be psFileSystemA?

(Okay, okay, I'll get my coat.)

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5117c6c into nodejs:main Jan 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 5117c6c

@Trott Trott deleted the file-system branch January 14, 2023 17:53
Trott added a commit to nodejs/remark-preset-lint-node that referenced this pull request Jan 14, 2023
@Trott
feat: add linting for "file system" vs. "filesystem"
70dbf99 
Ref: nodejs/node#46178
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@Trott @RafaelGSS
doc: use "file system" instead of "filesystem"
e2ca89d 
nodejs#44004 (comment)
PR-URL: nodejs#46178
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@Trott @RafaelGSS
doc: use "file system" instead of "filesystem"
f18ab94 
#44004 (comment)
PR-URL: #46178
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@Trott @juanarbol
doc: use "file system" instead of "filesystem"
4e54f85 
#44004 (comment)
PR-URL: #46178
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@Trott @juanarbol
doc: use "file system" instead of "filesystem"
d7a8c07 
#44004 (comment)
PR-URL: #46178
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
patrickm68 added a commit to patrickm68/Node-preset-lint that referenced this pull request Sep 14, 2023
@patrickm68
feat: add linting for "file system" vs. "filesystem"
b27654c 
Ref: nodejs/node#46178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@Flarna Flarna Flarna approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.