Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add trailing commas #46370

Merged
merged 1 commit into from
Jan 29, 2023
Merged

benchmark: add trailing commas #46370

merged 1 commit into from
Jan 29, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 26, 2023

Enforce trailing commas in more places, and add them where they were missing in the benchmark files.

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. child_process Issues and PRs related to the child_process subsystem. cluster Issues and PRs related to the cluster subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. diagnostics_channel Issues and PRs related to diagnostics channel dns Issues and PRs related to the dns subsystem. domain Issues and PRs related to the domain subsystem. http Issues or PRs related to the http subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Jan 26, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed http Issues or PRs related to the http subsystem. assert Issues and PRs related to the assert subsystem. cluster Issues and PRs related to the cluster subsystem. child_process Issues and PRs related to the child_process subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. dns Issues and PRs related to the dns subsystem. domain Issues and PRs related to the domain subsystem. v8 engine Issues and PRs related to the V8 dependency. diagnostics_channel Issues and PRs related to diagnostics channel labels Jan 26, 2023
@aduh95 aduh95 merged commit ca5f322 into nodejs:main Jan 29, 2023
@aduh95 aduh95 deleted the benchmark-dangle branch January 29, 2023 18:13
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 29, 2023

Landed in ca5f322

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@aduh95 @ruyadorno
benchmark: add trailing commas
524eec7 
PR-URL: #46370
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@aduh95 @juanarbol
benchmark: add trailing commas
e028a28 
PR-URL: #46370
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@aduh95 @juanarbol
benchmark: add trailing commas
37148c4 
PR-URL: #46370
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@aduh95 @juanarbol
benchmark: add trailing commas
6f91c8e 
PR-URL: #46370
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @jasnell @anonrig @MoLow @nodejs-github-bot