stream: make readable byte stream cloneable #46437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhafraDev
commented
Jan 31, 2023
| return; | ||
|
|
||
| // eslint-disable-next-line no-constructor-return | ||
| return makeTransferable(this); |
There was a problem hiding this comment.
btw this pattern is used right below this so I copied it from there, rather than separating onto separate lines.
node/lib/internal/webstreams/readablestream.js
Lines 295 to 296 in 938341a
|
is this and #45955 PR solving the same thing I think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows cloning web byte ReadableStreams.
Fixes: #46296