Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] test: remove cjs loader from stack traces #46535

Closed
wants to merge 1 commit into from
Closed

[v16.x backport] test: remove cjs loader from stack traces #46535

wants to merge 1 commit into from

Conversation

GeoffreyBooth
Copy link
Member

PR-URL: #44197
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Michaël Zasso targos@protonmail.com

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v16.x labels Feb 7, 2023
GeoffreyBooth added a commit to GeoffreyBooth/node that referenced this pull request Feb 7, 2023
@GeoffreyBooth
test: remove cjs loader from stack traces
255d0f5 
PR-URL: nodejs#44197
Backport-PR-URL: nodejs#46535
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@GeoffreyBooth GeoffreyBooth force-pushed the backport-fix-message-tests branch from 51436d0 to 255d0f5 Compare February 7, 2023 01:38
@GeoffreyBooth GeoffreyBooth changed the title test: remove cjs loader from stack traces [v16.x backport] test: remove cjs loader from stack traces Feb 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49459/

@GeoffreyBooth
test: remove cjs loader from stack traces
200f270 
PR-URL: nodejs#44197
Backport-PR-URL: nodejs#46535
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49461/

@GeoffreyBooth GeoffreyBooth force-pushed the backport-fix-message-tests branch from 255d0f5 to 200f270 Compare February 7, 2023 02:25
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49462/

@GeoffreyBooth GeoffreyBooth added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 7, 2023
BethGriggs
BethGriggs reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff LGTM, but would appreciate a second review (perhaps @targos?) before landing

targos
targos approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test-only changes. I think we can rubber-stamp.

BethGriggs pushed a commit that referenced this pull request Mar 27, 2023
@GeoffreyBooth @BethGriggs
test: remove cjs loader from stack traces
fc47d58 
PR-URL: #44197
Backport-PR-URL: #46535
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs
Copy link
Member

Landed in fc47d58

@BethGriggs BethGriggs closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs left review comments

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeoffreyBooth @nodejs-github-bot @BethGriggs @targos