-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: copy postject-api.h
and LICENSE
to the deps
folder
#46582
deps: copy postject-api.h
and LICENSE
to the deps
folder
#46582
Conversation
Review requested:
|
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: nodejs#45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
54baca1
to
2c626f5
Compare
Although this has the
needs-ci
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp approval :)
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: #45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in a37c083 |
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: #45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: nodejs#45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: #45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Since
postject-api.h
gets compiled into Node.js, it makes more sense to put it in thedeps
directory instead oftest/fixtures
.Refs: #45038 (comment)
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @mhdawson @nodejs/single-executable