Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] test: add WPTRunner support for variants and generating WPT reports #46767

Closed
wants to merge 3 commits into from
Closed

[v18.x backport] test: add WPTRunner support for variants and generating WPT reports #46767

wants to merge 3 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Feb 22, 2023 •
edited
Loading

Backports #46498, #46778, and #46804 to v18.x.

Enables WPT Report for future v18.x LTS releases.

@panva
test: add WPTRunner support for variants and generating WPT reports
8812c56 
PR-URL: nodejs#46498
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Backport-PR-URL: nodejs#46767
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Feb 22, 2023
@panva panva marked this pull request as ready for review February 22, 2023 10:27
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49877/

anonrig
anonrig approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. wip Issues and PRs that are still a work in progress. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. wip Issues and PRs that are still a work in progress. labels Feb 22, 2023
panva added a commit to panva/node that referenced this pull request Feb 22, 2023
@panva
test: fix default WPT titles
f88b581 
PR-URL: nodejs#46778
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Backport-PR-URL: nodejs#46767
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed wip Issues and PRs that are still a work in progress. labels Feb 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva
test: fix default WPT titles
5d45158 
PR-URL: nodejs#46778
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Backport-PR-URL: nodejs#46767
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Feb 23, 2023
Open
31 tasks
@panva panva marked this pull request as ready for review February 25, 2023 19:35
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50002/

@github-actions github-actions bot mentioned this pull request Feb 26, 2023
Open
15 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50012/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50022/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50025/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50026/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50034/

@panva
Copy link
Member Author

panva commented Feb 26, 2023

cc @nodejs/backporters if possible, please land 🙏 so that the next v18.x tagged release starts submitting runs to wpt.fyi like nightly and 19.x already do.

This does not affect the build, it merely enables the daily wpt workflow to create the report for future v18.x releases.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50038/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50040/

@github-actions github-actions bot mentioned this pull request Feb 27, 2023
Open
13 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50043/

@panva panva mentioned this pull request Feb 27, 2023
Closed
This was referenced Feb 28, 2023
Open
Open
@panva panva mentioned this pull request Mar 3, 2023
Merged
@juanarbol juanarbol removed the needs-ci PRs that need a full CI run. label Mar 5, 2023
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@panva @juanarbol
test: add WPTRunner support for variants and generating WPT reports
5f422c4 
PR-URL: #46498
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Backport-PR-URL: #46767
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@panva @juanarbol
test: fix default WPT titles
162e340 
PR-URL: #46778
Backport-PR-URL: #46767
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@panva @juanarbol
test: fix WPT title when no META title is present
de64315 
PR-URL: #46804
Backport-PR-URL: #46767
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@juanarbol
Copy link
Member

Landed in 492fc95...de64315

@juanarbol juanarbol closed this Mar 5, 2023
@panva panva deleted the backport-46498-to-v18.x branch March 5, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @juanarbol @anonrig @richardlau