Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v19.x] deps: V8: cherry-pick f09dde9fbb54 #47239

Closed
wants to merge 1 commit into from
Closed

[v19.x] deps: V8: cherry-pick f09dde9fbb54 #47239

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Original commit message:

Revert "[resultdb] Add ResultDB indicator"

This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005.

Reason for revert: breaks flake bisect:
https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview

The change added the implicit requirement to run testing with
vpython3, which is not given everywhere.

Original change's description:
> [resultdb] Add ResultDB indicator
>
> Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later).
>
> If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator.
>
> To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 .
>
>
> V8-Recipe-Flags: resultdb
> Bug: v8:13316
> Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385
> Commit-Queue: Liviu Rau <liviurau@google.com>
> Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#83672}

Bug: v8:13316
Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#83677}

Refs: v8/v8@f09dde9
Fixes: nodejs/build#3221

cc @nodejs/v8-update

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 23, 2023
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v19.x v8 engine Issues and PRs related to the V8 dependency. labels Mar 23, 2023
@richardlau richardlau mentioned this pull request Mar 23, 2023
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50578/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5245/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5245/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50579/

@StefanStojanovic
Copy link
Contributor

@richardlau I've noticed Windows CI failed for this PR. This happened because this commit is missing from your branch. Please cherry-pick it and rerun the CI. The commit from my other PR fixes the test at hand, so once it lands, those changes will be sufficient on their own.

Additionally, by going through 2 builds started on this PR, I've seen that test-crypto-dh-odd-key failed on ARM64 in the second run. I reran it and the test passed. Since it failed with timeout and I didn't see it do so before, I'd not go so far as to mark it flaky, but I'll keep my eye on it.

@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 28, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Open
18 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Open
34 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Open
38 tasks
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5282/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51055/

gengjiawen
gengjiawen requested changes Apr 10, 2023
View reviewed changes
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase is wrong (currently 50 commits in this PR)

@richardlau
Copy link
Member Author

rebase is wrong (currently 50 commits in this PR)

This PR was correct until v19.x-staging was rebased 😞. I won't be able to fix this up until tonight or tomorrow.

@targos
Copy link
Member

targos commented Apr 10, 2023

There's no need to fix up. Last CI was green so we can land it

@richardlau
deps: V8: cherry-pick f09dde9fbb54
48fc442 
Original commit message:

    Revert "[resultdb] Add ResultDB indicator"

    This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005.

    Reason for revert: breaks flake bisect:
    https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview

    The change added the implicit requirement to run testing with
    vpython3, which is not given everywhere.

    Original change's description:
    > [resultdb] Add ResultDB indicator
    >
    > Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later).
    >
    > If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator.
    >
    > To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 .
    >
    >
    > V8-Recipe-Flags: resultdb
    > Bug: v8:13316
    > Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385
    > Commit-Queue: Liviu Rau <liviurau@google.com>
    > Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#83672}

    Bug: v8:13316
    Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131
    Auto-Submit: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#83677}

Refs: v8/v8@f09dde9
@github-actions github-actions bot mentioned this pull request Apr 12, 2023
Open
31 tasks
@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2023
@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51167/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5296/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5296/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5296/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5297/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5297/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5297/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51174/

@github-actions github-actions bot mentioned this pull request Apr 13, 2023
Open
36 tasks
@gengjiawen gengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 13, 2023
richardlau added a commit that referenced this pull request Apr 13, 2023
@richardlau
deps: V8: cherry-pick f09dde9fbb54
a978ca6 
Original commit message:

    Revert "[resultdb] Add ResultDB indicator"

    This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005.

    Reason for revert: breaks flake bisect:
    https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview

    The change added the implicit requirement to run testing with
    vpython3, which is not given everywhere.

    Original change's description:
    > [resultdb] Add ResultDB indicator
    >
    > Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later).
    >
    > If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator.
    >
    > To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 .
    >
    >
    > V8-Recipe-Flags: resultdb
    > Bug: v8:13316
    > Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385
    > Commit-Queue: Liviu Rau <liviurau@google.com>
    > Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#83672}

    Bug: v8:13316
    Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131
    Auto-Submit: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#83677}

Refs: v8/v8@f09dde9
PR-URL: #47239
Fixes: nodejs/build#3221
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau
Copy link
Member Author

Landed in a978ca6.

@gengjiawen FWIW commit-queue Add this label to land a pull request using GitHub Actions. only works on main.

@richardlau richardlau closed this Apr 13, 2023
@richardlau richardlau deleted the norequests-v19.x branch April 13, 2023 12:03
@richardlau richardlau mentioned this pull request Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@richardlau @nodejs-github-bot @StefanStojanovic @RafaelGSS @targos @gengjiawen