Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 11.3 #47251

Closed
wants to merge 8 commits into from
Closed

deps: update V8 to 11.3 #47251

wants to merge 8 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 25, 2023 •
edited
Loading

@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Mar 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 25, 2023
@targos targos mentioned this pull request Mar 25, 2023
Closed
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@miladfarca

This comment was marked as resolved.

Sign in to view
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@miladfarca

This comment was marked as resolved.

Sign in to view
@targos targos mentioned this pull request Mar 29, 2023
Merged
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
targos added a commit to targos/node that referenced this pull request Jan 30, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
9c8e1b8 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 31, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
2224349 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@nodejs-github-bot nodejs-github-bot mentioned this pull request Jan 31, 2025
Closed
targos added a commit that referenced this pull request Jan 31, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
1142f78 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #55014
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit to targos/node that referenced this pull request Jan 31, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
fb81457 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit that referenced this pull request Jan 31, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
c781c92 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit to targos/node that referenced this pull request Feb 1, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
b2c20ab 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 2, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
ad71c00 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 3, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
7ad7ba4 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 4, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
fb70ef8 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 5, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
0e6e5e8 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit to targos/node that referenced this pull request Feb 5, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
05bc962 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit that referenced this pull request Feb 5, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
a7917b3 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 6, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
598562f 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 7, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
b72561a 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 8, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
061be69 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit to targos/node that referenced this pull request Feb 8, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
5bb479d 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit that referenced this pull request Feb 8, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
2602ba1 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 9, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
ed05282 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 10, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
78daef4 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 12, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
7d22940 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 13, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
ece0dbf 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 14, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
4e6b3e6 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Feb 14, 2025
@targos @joyeecheung
deps: always define V8_EXPORT_PRIVATE as no-op
c6a6d2c 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 15, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
1441afc 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit that referenced this pull request Feb 15, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
b6025e0 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit that referenced this pull request Feb 15, 2025
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
15164d2 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 15, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
d744f01 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 16, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
f09def4 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Feb 17, 2025
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
3a9198c 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @miladfarca @panva @anonrig @gengjiawen @richardlau @RafaelGSS