-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic: add additional utilities for quic (part 2) #47289
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
jasnell
added
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
dont-land-on-v14.x
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
labels
Mar 29, 2023
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Mar 29, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
anonrig
reviewed
Mar 29, 2023
anonrig
approved these changes
Mar 29, 2023
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Mar 29, 2023
tniessen
reviewed
Mar 30, 2023
tniessen
approved these changes
Mar 30, 2023
Qard
approved these changes
Mar 31, 2023
* add TokenSecret, StatelessResetToken, RetryToken, and RegularToken * add SessionTicket implementation
Qard
approved these changes
Mar 31, 2023
Landed in d65ae9f |
jasnell
added a commit
that referenced
this pull request
Mar 31, 2023
* add TokenSecret, StatelessResetToken, RetryToken, and RegularToken * add SessionTicket implementation PR-URL: #47289 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
lib / src
Issues and PRs related to general changes in the lib or src directory.
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second PR incrementally adding QUIC impl details. Again, the idea is to space these out over multiple PRS to make it easier to review instead of the big monolith that #44325 is. Easiest to review each commit individually.