Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: color errors only when colors are avilable #47394

Merged
merged 1 commit into from
Apr 4, 2023
Merged

test_runner: color errors only when colors are avilable #47394

merged 1 commit into from
Apr 4, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Apr 3, 2023

Fixes: #47393

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Apr 3, 2023
cjihrig
cjihrig approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - is it possible to add a test for this behavior?

@MoLow
Copy link
Member Author

MoLow commented Apr 3, 2023

LGTM - is it possible to add a test for this behavior?

there is a test, it was flaky :)

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50897/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50902/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50907/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50909/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50912/

@deokjinkim
Copy link
Contributor

deokjinkim commented Apr 4, 2023 •
edited
Loading

@MoLow Commit title has typo(avilable => available).

@MoLow
Copy link
Member Author

MoLow commented Apr 4, 2023

@MoLow Commit title has typo(avilable => available).

thanks, I will amend when landing

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50913/

@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2023
@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 4, 2023
@MoLow
test_runner: color errors only when colors are available
7ec93fb 
PR-URL: nodejs#47394
Fixes: nodejs#47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
@MoLow
Copy link
Member Author

MoLow commented Apr 4, 2023

Landed in 7ec93fb

@Trott Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
@MoLow MoLow merged commit 7ec93fb into nodejs:main Apr 4, 2023
@MoLow MoLow deleted the fix-spec-reporter-fluke branch April 4, 2023 16:01
@github-actions github-actions bot mentioned this pull request Apr 5, 2023
Open
26 tasks
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@MoLow @RafaelGSS
test_runner: color errors only when colors are available
9f465cd 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@MoLow @RafaelGSS
test_runner: color errors only when colors are available
d7bd288 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@MoLow @RafaelGSS
test_runner: color errors only when colors are available
120dc25 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@MoLow @RafaelGSS
test_runner: color errors only when colors are available
9c1f7b6 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@MoLow @RafaelGSS
test_runner: color errors only when colors are available
bc6511a 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@MoLow @RafaelGSS
test_runner: color errors only when colors are available
401d7b1 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
test_runner: color errors only when colors are available
ad81687 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test_runner: color errors only when colors are available
0b32a8c 
PR-URL: nodejs#47394
Fixes: nodejs#47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test message/test_runner_output_spec_reporter is flaky
6 participants
@MoLow @nodejs-github-bot @deokjinkim @Trott @anonrig @cjihrig