-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools, test: enable space-in-parens ESLint rule #4753
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
force-pushed
the
space-in-parens
branch
from
January 19, 2016 02:27
bd6418b
to
f9efb7a
Compare
LGTM |
1 similar comment
LGTM |
silverwind
added a commit
that referenced
this pull request
Jan 19, 2016
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
silverwind
added a commit
that referenced
this pull request
Jan 19, 2016
PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 19, 2016
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 19, 2016
PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 20, 2016
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 20, 2016
PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 28, 2016
PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 28, 2016
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2016
PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2016
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: #4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 13, 2016
PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 13, 2016
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This came up in #4743 (comment). There were only 7 violations, all of them in
test
.