node-api: remove unused mark_arraybuffer_as_untransferable #47557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
napi_create_external_arraybuffer creates the arraybuffer with node::Buffer, which already marks the buffer as untransferable. The napi_env__::mark_arraybuffer_as_untransferable is not used anymore.
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Apr 14, 2023
legendecas
added
node-api
anonrig
added
the
author ready
github-actions
bot
removed
the
request-ci
33 tasks
lpinca
approved these changes
Apr 15, 2023
jasnell
approved these changes
Apr 17, 2023
35 tasks
|
Landed in 682256c |
legendecas
added a commit
that referenced
this pull request
Apr 18, 2023
napi_create_external_arraybuffer creates the arraybuffer with node::Buffer, which already marks the buffer as untransferable. The napi_env__::mark_arraybuffer_as_untransferable is not used anymore. PR-URL: #47557 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 2, 2023
napi_create_external_arraybuffer creates the arraybuffer with node::Buffer, which already marks the buffer as untransferable. The napi_env__::mark_arraybuffer_as_untransferable is not used anymore. PR-URL: #47557 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
napi_create_external_arraybuffer creates the arraybuffer with node::Buffer, which already marks the buffer as untransferable. The napi_env__::mark_arraybuffer_as_untransferable is not used anymore. PR-URL: #47557 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
napi_create_external_arraybuffer creates the arraybuffer with node::Buffer, which already marks the buffer as untransferable. The napi_env__::mark_arraybuffer_as_untransferable is not used anymore. PR-URL: nodejs#47557 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
napi_create_external_arraybuffercreates the arraybuffer withnode::Buffer, which already marks the buffer as untransferable.The
napi_env__::mark_arraybuffer_as_untransferableis not usedanymore.