-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: port flaky wpt/html/webappapis/timers tests to test/sequential #47657
Conversation
cc @nodejs/timers |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I understand the motivation, but is there an alternative, such as adding an option to run some WPTs sequentially or so? |
Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up... |
ping @nodejs/timers |
If we're already parallelizing WPT suites in the WPT runner, shouldn't we run |
I'm just looking at nodejs/reliability and wpt/test-webcrypto also occasionally crashes. So i'm going to open a PR reverting the python side of things to sequential and also introducing maximum parallelism option in the WPTRunner. |
Closing in favour of #47834 |
wpt/test-timers
has been unreliable since we've re-enabled parallel execution in WPTs. This PR removes thehtml/webappapis/timers
WPTs and ports the tests to test/sequential instead.e.g.
nodejs/reliability#548