Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,test: fix concurrency option of test() #47734

Merged
merged 1 commit into from
Apr 28, 2023
Merged

doc,test: fix concurrency option of test() #47734

merged 1 commit into from
Apr 28, 2023

Commits on Apr 26, 2023

  1. doc,test: fix concurrency option of test() 

    The documentation appears to still be wrong w.r.t. the meaning of the
concurrency option of the test() function. The implementation appears to
default to Infinity when the option is set to true. Is that intended or
a good idea? I don't know. It certainly makes more sense than what the
documentation says (which is basing the number of concurrent tasks
within a single thread on the number of CPU cores).

This changes the documentation to hopefully match the implementation and
adds a test that rules out the (rather arbitrary) behavior described in
the documentation.

Refs: nodejs#47365
Refs: nodejs#47642
    @tniessen
    tniessen committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    9122dba View commit details
    Browse the repository at this point in the history