src: clarify the parameter name in Permission::Apply
#47874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
This fixes confusing parameter names. They are references to set allow-permission. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
force-pushed
the
main.fix/doc/permission-230505.Fri.baaf
branch
from
77416b8
to
21642e7
Compare
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
force-pushed
the
main.fix/doc/permission-230505.Fri.baaf
branch
from
1ff3516
to
72cab67
Compare
RafaelGSS
reviewed
May 5, 2023
There was a problem hiding this comment.
This PR does two changes:
- Correctly fix the parameter name
deny->allow - Use
is_all_allowed_instead ofdeny_all.
While I 100% agree with the first change, the second one seems odd to me. I feel that reading deny_all_ = true by default way clear than is_all_allowed_ = false
… and worker" This reverts commit 72cab67. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
|
@RafaelGSS Thanks for the review. I reverted renaming |
daeyeon
added
the
commit-queue-squash
github-actions
bot
removed
the
request-ci
daeyeon
added
the
author ready
debadree25
approved these changes
May 6, 2023
debadree25
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 39973c6 |
targos
pushed a commit
that referenced
this pull request
May 12, 2023
This fixes confusing parameter names. They are references to set allow-permission. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #47874 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
This fixes confusing parameter names. They are references to set allow-permission. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #47874 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This fixes confusing parameter names. They are references to set allow-permission. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: nodejs#47874 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first parameter is to set allow-permission, but its name declaration is
deny. This removes any confusion./cc @RafaelGSS
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com