dgram: convert macro to template #47891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not pretty either way, but a template is still preferable over a macro.
tniessen
added
dgram
|
Review requested:
|
bnoordhuis
approved these changes
May 6, 2023
tniessen
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
debadree25
added
the
commit-queue
This was referenced May 7, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 29e6dd1 |
This was referenced May 9, 2023
targos
pushed a commit
that referenced
this pull request
May 12, 2023
It's not pretty either way, but a template is still preferable over a macro. PR-URL: #47891 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced May 13, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
It's not pretty either way, but a template is still preferable over a macro. PR-URL: #47891 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
It's not pretty either way, but a template is still preferable over a macro. PR-URL: nodejs#47891 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not pretty either way, but a template is still preferable over a macro.