-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic: the next round #47927
Closed
Closed
quic: the next round #47927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
May 8, 2023
anonrig
reviewed
May 9, 2023
jasnell
force-pushed
the
quic-part-6
branch
4 times, most recently
from
May 9, 2023 22:17
53d8afd
to
1e76412
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
dont-land-on-v16.x
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
labels
May 9, 2023
jasnell
force-pushed
the
quic-part-6
branch
2 times, most recently
from
May 10, 2023 02:54
a325de7
to
65f213b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 11, 2023
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
May 27, 2023
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 27, 2023
Landed in 6d2811f |
jasnell
added a commit
that referenced
this pull request
May 27, 2023
* add QUIC_SESSION and QUIC_STREAM to AsyncWrap * update definitions in quic/bindingdata.h * fixup minor discrepancies in cid.h/cid.cc * add convenience operator in struct Path * fixup defs.h macro definitions * fixups in quic/preferredaddress.h/cc * fixups in src/quic/tokens.h/cc * fixups in quic/transportparams.h/cc * fixups in quic/tlscontext.h/cc * add quic/streams.h/cc placeholder * add quic session/application implementation PR-URL: #47927 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced May 28, 2023
@jasnell Why are these PRs dont-land-on-v20.x ? |
This was referenced May 31, 2023
This was referenced Jul 3, 2023
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
* add QUIC_SESSION and QUIC_STREAM to AsyncWrap * update definitions in quic/bindingdata.h * fixup minor discrepancies in cid.h/cid.cc * add convenience operator in struct Path * fixup defs.h macro definitions * fixups in quic/preferredaddress.h/cc * fixups in src/quic/tokens.h/cc * fixups in quic/transportparams.h/cc * fixups in quic/tlscontext.h/cc * add quic/streams.h/cc placeholder * add quic session/application implementation PR-URL: nodejs#47927 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
* add QUIC_SESSION and QUIC_STREAM to AsyncWrap * update definitions in quic/bindingdata.h * fixup minor discrepancies in cid.h/cid.cc * add convenience operator in struct Path * fixup defs.h macro definitions * fixups in quic/preferredaddress.h/cc * fixups in src/quic/tokens.h/cc * fixups in quic/transportparams.h/cc * fixups in quic/tlscontext.h/cc * add quic/streams.h/cc placeholder * add quic session/application implementation PR-URL: nodejs#47927 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a bit larger as it adds everything for
Session
which is the bulk of the quic implementation.