-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-esm-loader-http-imports as flaky #47987
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:test-es-module-flaky-esm-loader-http-imports
May 15, 2023
Merged
test: mark test-esm-loader-http-imports as flaky #47987
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:test-es-module-flaky-esm-loader-http-imports
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has been failing occasionally for weeks. Refs: nodejs#47836 Refs: nodejs/reliability#564
tniessen
added
test
Issues and PRs related to the tests.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
loaders
Issues and PRs related to ES module loaders
labels
May 13, 2023
nodejs-github-bot
added
esm
Issues and PRs related to the ECMAScript Modules implementation.
needs-ci
PRs that need a full CI run.
labels
May 13, 2023
cc @nodejs/build |
panva
approved these changes
May 14, 2023
tniessen
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
May 14, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 14, 2023
aduh95
approved these changes
May 14, 2023
tniessen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 14, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 15, 2023
Landed in 92d3611 |
targos
pushed a commit
that referenced
this pull request
May 15, 2023
This test has been failing occasionally for weeks. Refs: #47836 Refs: nodejs/reliability#564 PR-URL: #47987 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
This test has been failing occasionally for weeks. Refs: #47836 Refs: nodejs/reliability#564 PR-URL: #47987 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This test has been failing occasionally for weeks. Refs: nodejs#47836 Refs: nodejs/reliability#564 PR-URL: nodejs#47987 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
esm
Issues and PRs related to the ECMAScript Modules implementation.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
loaders
Issues and PRs related to ES module loaders
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been failing occasionally for weeks.
Refs: #47836
Refs: nodejs/reliability#564