Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: debug log for nghttp3 #47992

Merged
merged 1 commit into from
May 14, 2023
Merged

tools: debug log for nghttp3 #47992

merged 1 commit into from
May 14, 2023

Conversation

marco-ippolito
Copy link
Member

Refs: #47576

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 13, 2023
@marco-ippolito marco-ippolito mentioned this pull request May 13, 2023
Closed
@marco-ippolito marco-ippolito added the fast-track PRs that do not need to wait for 48 hours to land. label May 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @marco-ippolito. Please 👍 to approve.

tniessen
tniessen reviewed May 14, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do GitHub files have stable checksums? If so, it would be good to log the sha256sum or so of the downloaded archive.

@marco-ippolito
Copy link
Member Author

This is a good idea! It might be something we want to do for all archive we download. Ill look into it

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit d27301d into nodejs:main May 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d27301d

targos pushed a commit that referenced this pull request May 14, 2023
@marco-ippolito @targos
tools: debug log for nghttp3
1a1bc0b 
PR-URL: #47992
Refs: #47576
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 15, 2023
@marco-ippolito @targos
tools: debug log for nghttp3
a4e261e 
PR-URL: #47992
Refs: #47576
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
@tniessen tniessen mentioned this pull request May 19, 2023
Merged
@fasenderos fasenderos mentioned this pull request May 20, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: debug log for nghttp3
c992668 
PR-URL: #47992
Refs: #47576
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
tools: debug log for nghttp3
89e068a 
PR-URL: nodejs#47992
Refs: nodejs#47576
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen left review comments

@juanarbol juanarbol juanarbol approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marco-ippolito @nodejs-github-bot @jasnell @anonrig @tniessen @deokjinkim @juanarbol