http: make the error more descriptive #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make the commit log more descriptive, please? :-) See CONTRIBUTING.md for the desired format and please check that |
qzaidi
changed the title
|
@qzaidi the commit log (run |
Qard
pushed a commit
to Qard/node
that referenced
this pull request
Jan 30, 2015
PR-URL: nodejs#480 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
|
LGTM |
|
Landed in cf3e908, with an amended commit message and modifications to conform to line length restrictions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think printing the name of the header whose value is undefined would make debugging slightly more easy.