Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix Windows code snippet tags #48100

Merged
merged 1 commit into from
May 21, 2023
Merged

doc: fix Windows code snippet tags #48100

merged 1 commit into from
May 21, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 21, 2023

Those were wrongly marked as bash (that's my bad, it's coming from #48082), when the text around it was referencing PowerShell or Command Prompt.

@aduh95
doc: fix Windows code snippet tags
b5fd384 
Those were wrongly marked as `bash`, when the text around it was
referencing PowerShell or Command Prompt.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 21, 2023
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 21, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

RaisinTen
RaisinTen reviewed May 21, 2023
View reviewed changes
doc/api/single-executable-applications.md
cp (Get-Command node).Source hello.exe
```

Using Command Prompt:

```bash
```text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```text
```cmd

Shouldn't this be cmd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter won’t let me do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so here's the total list:

node/tools/lint-md/lint-md.mjs

Lines 20828 to 20843 in 260092e

"bash",
"c",
"cjs",
"coffee",
"console",
"cpp",
"diff",
"http",
"js",
"json",
"markdown",
"mjs",
"powershell",
"r",
"text",
"ts",

I think console still makes more sense than text here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree, console is meant for showing the output of commands (with optionally the command themselves when prefixed with $ or >), so it wouldn’t apply here. If you feel strongly that text is not correct, let’s add cmd to the list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about it :)

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 30870d1 into nodejs:main May 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 30870d1

@aduh95 aduh95 deleted the windows-no-bash branch May 21, 2023 13:21
fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
@aduh95 @fasenderos
doc: fix Windows code snippet tags
5bfdce8 
Those were wrongly marked as `bash`, when the text around it was
referencing PowerShell or Command Prompt.

PR-URL: nodejs#48100
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
@aduh95 @fasenderos
doc: fix Windows code snippet tags
c3815c7 
Those were wrongly marked as `bash`, when the text around it was
referencing PowerShell or Command Prompt.

PR-URL: nodejs#48100
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
targos pushed a commit that referenced this pull request May 30, 2023
@aduh95 @targos
doc: fix Windows code snippet tags
f30ba5c 
Those were wrongly marked as `bash`, when the text around it was
referencing PowerShell or Command Prompt.

PR-URL: #48100
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
@danielleadams danielleadams added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Jul 3, 2023
@danielleadams
Copy link
Contributor

Blocked by #47125

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
doc: fix Windows code snippet tags
1221730 
Those were wrongly marked as `bash`, when the text around it was
referencing PowerShell or Command Prompt.

PR-URL: nodejs#48100
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
doc: fix Windows code snippet tags
4ce9bf0 
Those were wrongly marked as `bash`, when the text around it was
referencing PowerShell or Command Prompt.

PR-URL: nodejs#48100
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen left review comments

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@Mesteery Mesteery Mesteery approved these changes

@tniessen tniessen tniessen approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @danielleadams @targos @tniessen @RaisinTen @Mesteery @VoltrexKeyva