Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,doc,sea: run SEA tests on ppc64 #48111

Merged
merged 1 commit into from
May 24, 2023

Conversation

RaisinTen
Copy link
Contributor

The recent Postject upgrade, #48072, included a performance improvement for the injection operation (see nodejs/postject#86), so now it might be possible to run the SEA tests on the ppc64 architecture runners on Jenkins, which was previously getting timed out.

The recent Postject upgrade, nodejs#48072,
included a performance improvement for the injection operation
(see nodejs/postject#86), so now it might be
possible to run the SEA tests on the ppc64 architecture runners on
Jenkins, which was previously getting timed out.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 22, 2023
@nodejs-github-bot

This comment was marked as outdated.

@RaisinTen
Copy link
Contributor Author

It works! https://ci.nodejs.org/job/node-test-commit-plinux/48376/nodes=rhel8-ppc64le/

ok 3919 sequential/test-single-executable-application
  ---
  duration_ms: 8346.55700
  ...
ok 3920 sequential/test-single-executable-application-disable-experimental-sea-warning
  ---
  duration_ms: 6940.95800
  ...

@RaisinTen RaisinTen marked this pull request as ready for review May 22, 2023 11:22
@RaisinTen RaisinTen added the single-executable Issues and PRs related to single-executable applications label May 22, 2023
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 22, 2023
@nodejs-github-bot
Copy link
Collaborator

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit a7a1fc5 into nodejs:main May 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in a7a1fc5

@RaisinTen RaisinTen deleted the run-sea-tests-on-ppc64 branch May 24, 2023 15:14
targos pushed a commit that referenced this pull request May 30, 2023
The recent Postject upgrade, #48072,
included a performance improvement for the injection operation
(see nodejs/postject#86), so now it might be
possible to run the SEA tests on the ppc64 architecture runners on
Jenkins, which was previously getting timed out.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #48111
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
The recent Postject upgrade, #48072,
included a performance improvement for the injection operation
(see nodejs/postject#86), so now it might be
possible to run the SEA tests on the ppc64 architecture runners on
Jenkins, which was previously getting timed out.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #48111
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
The recent Postject upgrade, nodejs#48072,
included a performance improvement for the injection operation
(see nodejs/postject#86), so now it might be
possible to run the SEA tests on the ppc64 architecture runners on
Jenkins, which was previously getting timed out.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48111
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
The recent Postject upgrade, nodejs#48072,
included a performance improvement for the injection operation
(see nodejs/postject#86), so now it might be
possible to run the SEA tests on the ppc64 architecture runners on
Jenkins, which was previously getting timed out.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48111
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
The recent Postject upgrade, nodejs#48072,
included a performance improvement for the injection operation
(see nodejs/postject#86), so now it might be
possible to run the SEA tests on the ppc64 architecture runners on
Jenkins, which was previously getting timed out.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48111
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants