Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve HMAC key recommendations #48121

Merged
merged 1 commit into from
May 24, 2023
Merged

doc: improve HMAC key recommendations #48121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3391,7 +3391,11 @@ On recent releases of OpenSSL, `openssl list -digest-algorithms` will
display the available digest algorithms.

The `key` is the HMAC key used to generate the cryptographic HMAC hash. If it is
a [`KeyObject`][], its type must be `secret`.
a [`KeyObject`][], its type must be `secret`. If it is a string, please consider
[caveats when using strings as inputs to cryptographic APIs][]. If it was
obtained from a cryptographically secure source of entropy, such as
[`crypto.randomBytes()`][] or [`crypto.generateKey()`][], its length should not
exceed the block size of `algorithm` (e.g., 512 bits for SHA-256).

Example: generating the sha256 HMAC of a file

Expand Down Expand Up @@ -3665,6 +3669,9 @@ generateKey('hmac', { length: 512 }, (err, key) => {
});
```

The size of a generated HMAC key should not exceed the block size of the
underlying hash function. See [`crypto.createHmac()`][] for more information.

### `crypto.generateKeyPair(type, options, callback)`

<!-- YAML
Expand Down Expand Up @@ -3935,6 +3942,9 @@ const key = generateKeySync('hmac', { length: 512 });
console.log(key.export().toString('hex')); // e89..........41e
```

The size of a generated HMAC key should not exceed the block size of the
underlying hash function. See [`crypto.createHmac()`][] for more information.

### `crypto.generatePrime(size[, options[, callback]])`

<!-- YAML
Expand Down Expand Up @@ -6030,6 +6040,7 @@ See the [list of SSL OP Flags][] for details.
[`crypto.createSecretKey()`]: #cryptocreatesecretkeykey-encoding
[`crypto.createSign()`]: #cryptocreatesignalgorithm-options
[`crypto.createVerify()`]: #cryptocreateverifyalgorithm-options
[`crypto.generateKey()`]: #cryptogeneratekeytype-options-callback
[`crypto.getCurves()`]: #cryptogetcurves
[`crypto.getDiffieHellman()`]: #cryptogetdiffiehellmangroupname
[`crypto.getHashes()`]: #cryptogethashes
Expand Down