repl: display dynamic import version in error message. #48129

hemanth · 2023-05-22T23:49:14Z

❯ ./out/Release/node
Welcome to Node.js v21.0.0-pre.
Type ".help" for more information.
> import {foo, bar} from 'mo';
import {foo, bar} from 'mo';
^^^^^^

Uncaught:
SyntaxError: Cannot use import statement inside the Node.js REPL, alternatively use dynamic import: const {foo,bar} = await import('mo');

aduh95

Can you please remove the unrelated spacing changes, and ensure we have a test for all types of static import statements as well as tests for when there are more than one statement (e.g. const a=1;import 'url';const b=2).

hemanth · 2023-05-23T12:04:17Z

@aduh95 I ran make lint-js-fix, looks better now?

const a=1;import 'url';const b=2 that's a good catch, pretty sure that would bomb, will have a look.

update: ha! will fix it.

>const a=1;import 'url';const b=2
const a=1;import 'url';const b=2
          ^^^^^^

Uncaught:
SyntaxError: Cannot use import statement inside the Node.js REPL, alternatively use dynamic import: const  = await import('url');

Meanwhile, any idea, why this could happen? Looks like a parse error?

> import comeOn from \'fhqwhgads\'
Uncaught [SyntaxError: Expecting Unicode escape sequence \uXXXX (1:20)
] {
  pos: 20,
  loc: Position { line: 1, column: 20 },
  raisedAt: 20
}

aduh95 · 2023-05-23T12:24:21Z

import comeOn from \'fhqwhgads\' is not valid ECMAScript (mind the backslashes), so it's expected that it produces a parse error, or am I missing something?

hemanth · 2023-05-23T19:24:59Z

On v20.1.0 we see:

❯ node
Welcome to Node.js v20.1.0.
Type ".help" for more information.
> import comeOn from \'fhqwhgads\'
import comeOn from \'fhqwhgads\'
^^^^^^

Uncaught:
SyntaxError: Cannot use import statement inside the Node.js REPL, alternatively use dynamic import

^ That should be because it doesn't even parse till \'fhqwhgads\' so the expected behavior with the new messaging would be?

hemanth · 2023-05-23T19:28:09Z

Works in runkit, because it interpolates the string well?

hemanth · 2023-05-25T05:52:01Z

@aduh95 How come the test passes for:

{
  send: 'import "foo";',
  expect: ''
}

❯ tools/test.py test/parallel/test-repl-*
[00:03|% 100|+  72|-   0]: Done                                               

All tests passed.

hemanth · 2023-05-27T07:41:34Z

@aduh95 internal/deps/acorn/acorn/dist/acorn and internal/deps/acorn/acorn-walk/dist/walk have different implementations compared what is on npm.

Currently stuck with:

Uncaught TypeError: baseVisitor[type] is not a function
    at c (node:internal/deps/acorn/acorn-walk/dist/walk:45:24)
    at Object.ancestor (node:internal/deps/acorn/acorn-walk/dist/walk:48:7)
    at toDynamicImport (node:repl:238:13)
    at Domain.debugDomainError (node:repl:713:62)
    at Domain.emit (node:events:511:28)
    at Domain.emit (node:domain:489:12)
    at finish (node:repl:949:22)
    at finishExecution (node:repl:571:7)
    at REPLServer.defaultEval (node:repl:660:7)
    at bound (node:domain:433:15)

Parser(options, input, startPos) param positions are different...

aduh95 · 2023-05-27T10:49:29Z

That's unlikely, we use npm to download new versions.

node/tools/dep_updaters/update-acorn.sh

Line 36 in 300f68e

    
           "$NODE" "$NPM" install --global-style --no-bin-links --ignore-scripts "acorn@$NEW_VERSION"

hemanth · 2023-05-27T12:42:47Z

acron#L9 reads constructor(options, input, startPos) their readme interface reads parse(input, options) ha, maybe it is parse vs Parser.

Also, everything works fine in runkit gist.

hemanth · 2023-05-27T13:23:00Z

Ah, indeed it was Parser vs parse.

  code: 'ERR_ASSERTION',
  actual: "SyntaxError: Cannot use import statement inside the Node.js REPL, alternatively use dynamic import: const comeOn = await import('fhqwhgads');",
  expected: /^SyntaxError: .* dynamic import: const comeOn = await import('fhqwhgads');/,
  operator: 'match'

RE is not being respected? /^SyntaxError: .* dynamic import:..

Enhance the REPL message for static import error message. ``` > import {foo, bar} from 'moo'; import {foo, bar} from 'moo'; ^^^^^^ Uncaught: SyntaxError: .* dynamic import: const {foo,bar} = await import('moo'); ```

hemanth · 2023-05-27T14:57:22Z

Build says: Error: The operation was canceled. @aduh95 is there a keyword to re-trigger CI?

Also, finally looks like we have all the variants covered:

aduh95 · 2023-05-27T15:09:14Z

If you push a commit to get rid of all the unrelated space changes, that should trigger a new CI run

hemanth · 2023-05-27T16:08:01Z

Ha! The spaces changes came in from lint-fix I presume.

…

On Sat, May 27, 2023, 8:09 AM Antoine du Hamel ***@***.***> wrote: If you push a commit to get rid of all the unrelated space changes, that should trigger a new CI run — Reply to this email directly, view it on GitHub <#48129 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEPC2G3CGRJY4ACLMNOO3XIIKKLANCNFSM6AAAAAAYLC4TYY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

aduh95 · 2023-05-27T18:08:32Z

The spaces changes came in from lint-fix I presume.

That's unlikely, but anyway, you would need to get rid of the unrelated changes to move this forward.

lib/repl.js

test/parallel/test-repl.js

lib/repl.js

Co-authored-by: Jordan Harband <ljharb@gmail.com>

nodejs-github-bot · 2023-06-10T18:24:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52190/

nodejs-github-bot · 2023-06-10T23:29:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52200/

nodejs-github-bot · 2023-06-11T08:10:40Z

Landed in 0c875bb

hemanth · 2023-06-11T14:22:54Z

🥳 Thank you @aduh95 and @ljharb 🤓

Enhance the REPL message for static import error message. ``` > import {foo, bar} from 'moo'; import {foo, bar} from 'moo'; ^^^^^^ Uncaught: SyntaxError: .* dynamic import: const {foo,bar} = await import('moo'); ``` PR-URL: #48129 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Enhance the REPL message for static import error message. ``` > import {foo, bar} from 'moo'; import {foo, bar} from 'moo'; ^^^^^^ Uncaught: SyntaxError: .* dynamic import: const {foo,bar} = await import('moo'); ``` PR-URL: nodejs#48129 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Enhance the REPL message for static import error message. ``` > import {foo, bar} from 'moo'; import {foo, bar} from 'moo'; ^^^^^^ Uncaught: SyntaxError: .* dynamic import: const {foo,bar} = await import('moo'); ``` PR-URL: #48129 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

ruyadorno · 2023-09-01T14:46:26Z

hi @hemanth this commit is breaking tests on v18.x-staging branch and will need manual backport in order to land on v18.

hemanth · 2023-09-01T17:01:55Z

Hey @ruyadorno Ill try to backport it, thanks for highlighting!

Enhance the REPL message for static import error message. ``` > import {foo, bar} from 'moo'; import {foo, bar} from 'moo'; ^^^^^^ Uncaught: SyntaxError: .* dynamic import: const {foo,bar} = await import('moo'); ``` PR-URL: #48129 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Enhance the REPL message for static import error message. ``` > import {foo, bar} from 'moo'; import {foo, bar} from 'moo'; ^^^^^^ Uncaught: SyntaxError: .* dynamic import: const {foo,bar} = await import('moo'); ``` PR-URL: nodejs/node#48129 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels May 22, 2023

hemanth force-pushed the main branch from 4f9b1e8 to 84ca0b2 Compare May 23, 2023 05:11

aduh95 reviewed May 23, 2023

View reviewed changes

hemanth force-pushed the main branch from 84ca0b2 to cd2c691 Compare May 24, 2023 23:06

hemanth closed this May 27, 2023

hemanth force-pushed the main branch from cd2c691 to d2a1f71 Compare May 27, 2023 14:14

hemanth reopened this May 27, 2023

repl: display dynamic import variant in static import error messages

3bb9b4e

Enhance the REPL message for static import error message. ``` > import {foo, bar} from 'moo'; import {foo, bar} from 'moo'; ^^^^^^ Uncaught: SyntaxError: .* dynamic import: const {foo,bar} = await import('moo'); ```

hemanth force-pushed the main branch from f7620bd to 3bb9b4e Compare May 27, 2023 14:27

aduh95 reviewed May 27, 2023

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

lib/repl.js Outdated Show resolved Hide resolved

test/parallel/test-repl.js Show resolved Hide resolved

fix: handle edge cases for toDynamicImport

653dd2b

hemanth force-pushed the main branch from c9a4d6b to 653dd2b Compare May 31, 2023 04:39

hemanth commented May 31, 2023

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

ljharb reviewed May 31, 2023

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

lib/repl.js Outdated Show resolved Hide resolved

lib/repl.js Outdated Show resolved Hide resolved

lib/repl.js Outdated Show resolved Hide resolved

lib/repl.js Outdated Show resolved Hide resolved

hemanth and others added 2 commits May 31, 2023 12:23

use primordials

65aff1f

Co-authored-by: Jordan Harband <ljharb@gmail.com>

__proto__ to null

d2891e1

Co-authored-by: Jordan Harband <ljharb@gmail.com>

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 10, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2023

github-actions bot mentioned this pull request Jun 11, 2023

CI Reliability 2023-06-11 nodejs/reliability#590

Open

25 tasks

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 11, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2023

nodejs-github-bot merged commit 0c875bb into nodejs:main Jun 11, 2023

This was referenced Jun 12, 2023

CI Reliability 2023-06-12 nodejs/reliability#591

Open

CI Reliability 2023-06-13 nodejs/reliability#592

Open

CI Reliability 2023-06-14 nodejs/reliability#593

Open

CI Reliability 2023-06-15 nodejs/reliability#594

Open

RafaelGSS mentioned this pull request Jul 3, 2023

v20.4.0 proposal #48643

Merged

ruyadorno mentioned this pull request Aug 29, 2023

v18.18.0 proposal #49220

Merged

ruyadorno added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Sep 1, 2023

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

hemanth mentioned this pull request Mar 21, 2024

REPL: import statement inside the Node.js REPL #48084

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repl: display dynamic import version in error message. #48129

repl: display dynamic import version in error message. #48129

hemanth commented May 22, 2023 •

edited

Loading

aduh95 left a comment

hemanth commented May 23, 2023 •

edited

Loading

aduh95 commented May 23, 2023

hemanth commented May 23, 2023 •

edited

Loading

hemanth commented May 23, 2023

hemanth commented May 25, 2023

hemanth commented May 27, 2023

aduh95 commented May 27, 2023

hemanth commented May 27, 2023

hemanth commented May 27, 2023

hemanth commented May 27, 2023 •

edited

Loading

aduh95 commented May 27, 2023

hemanth commented May 27, 2023 via email

aduh95 commented May 27, 2023

nodejs-github-bot commented Jun 10, 2023

nodejs-github-bot commented Jun 10, 2023

nodejs-github-bot commented Jun 11, 2023

hemanth commented Jun 11, 2023

ruyadorno commented Sep 1, 2023

hemanth commented Sep 1, 2023

repl: display dynamic import version in error message. #48129

repl: display dynamic import version in error message. #48129

Conversation

hemanth commented May 22, 2023 • edited Loading

aduh95 left a comment

Choose a reason for hiding this comment

hemanth commented May 23, 2023 • edited Loading

aduh95 commented May 23, 2023

hemanth commented May 23, 2023 • edited Loading

hemanth commented May 23, 2023

hemanth commented May 25, 2023

hemanth commented May 27, 2023

aduh95 commented May 27, 2023

hemanth commented May 27, 2023

hemanth commented May 27, 2023

hemanth commented May 27, 2023 • edited Loading

aduh95 commented May 27, 2023

hemanth commented May 27, 2023 via email

aduh95 commented May 27, 2023

nodejs-github-bot commented Jun 10, 2023

nodejs-github-bot commented Jun 10, 2023

nodejs-github-bot commented Jun 11, 2023

hemanth commented Jun 11, 2023

ruyadorno commented Sep 1, 2023

hemanth commented Sep 1, 2023

hemanth commented May 22, 2023 •

edited

Loading

hemanth commented May 23, 2023 •

edited

Loading

hemanth commented May 23, 2023 •

edited

Loading

hemanth commented May 27, 2023 •

edited

Loading