Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update Buffer.allocUnsafe documentation #48183

Merged
merged 1 commit into from
May 29, 2023
Merged

doc: update Buffer.allocUnsafe documentation #48183

merged 1 commit into from
May 29, 2023

Conversation

sinkhaha
Copy link
Contributor

Fixes: #42821

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels May 26, 2023
@sinkhaha
Copy link
Contributor Author

cc @jasnell

@sinkhaha sinkhaha changed the title doc: update Buffer.allocUnsafe description doc: update Buffer.allocUnsafe documentation May 26, 2023
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1e3631f into nodejs:main May 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1e3631f

targos pushed a commit that referenced this pull request May 30, 2023
@sinkhaha @targos
doc: update Buffer.allocUnsafe description
11918d7 
PR-URL: #48183
Fixes: #42821
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@sinkhaha @danielleadams
doc: update Buffer.allocUnsafe description
435b2c8 
PR-URL: #48183
Fixes: #42821
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@sinkhaha @MoLow
doc: update Buffer.allocUnsafe description
a2aa52b 
PR-URL: nodejs#48183
Fixes: nodejs#42821
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@sinkhaha @Ceres6
doc: update Buffer.allocUnsafe description
e488ac4 
PR-URL: nodejs#48183
Fixes: nodejs#42821
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@sinkhaha @Ceres6
doc: update Buffer.allocUnsafe description
daf1512 
PR-URL: nodejs#48183
Fixes: nodejs#42821
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer constructor not allocating at pool
4 participants
@sinkhaha @nodejs-github-bot @jasnell @lpinca