test: remove unnecessary noop function args to musNotCall()
#48513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Jun 21, 2023
|
s/musNotCall/mustNotCall/ in commit message |
test: remove unnecessary noop function args to `mustNotCall()`
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Jun 21, 2023
aduh95
added
the
commit-queue
HarshithaKP
approved these changes
Jun 22, 2023
30 tasks
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/48513 ✔ Done loading data for nodejs/node/pull/48513 ----------------------------------- PR info ------------------------------------ Title test: remove unnecessary noop function args to `musNotCall()` (#48513) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:must-not-noop -> nodejs:main Labels test, author ready, needs-ci Commits 2 - test: remove unnecessary noop function args to `musNotCall()` - amend! test: remove unnecessary noop function args to `musNotCall()` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/48513 Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Harshitha K P ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48513 Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Harshitha K P -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 21 Jun 2023 18:23:06 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48513#pullrequestreview-1491447001 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48513#pullrequestreview-1491730123 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/48513#pullrequestreview-1492586924 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-06-21T21:50:47Z: https://ci.nodejs.org/job/node-test-pull-request/52335/ - Querying data for job/node-test-pull-request/52335/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48513 From https://github.com/nodejs/node * branch refs/pull/48513/merge -> FETCH_HEAD ✔ Fetched commits as e9340038114f..3eb2f919471f -------------------------------------------------------------------------------- [main dfb982fc7f] test: remove unnecessary noop function args to `musNotCall()` Author: Antoine du Hamel Date: Wed Jun 21 20:18:12 2023 +0200 14 files changed, 17 insertions(+), 18 deletions(-) The previous cherry-pick is now empty, possibly due to conflict resolution. If you wish to commit it anyway, use:https://github.com/nodejs/node/actions/runs/5359408246 |
Trott
approved these changes
Jun 23, 2023
25 tasks
|
Landed in d9f394e |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
PR-URL: #48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.