Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix code type of markdowns #4858

Closed
wants to merge 1 commit into from
Closed

Conversation

JacksonTian
Copy link
Contributor

  1. correct code type in addons.markdown
  2. add missed code type in crypto.markdown

1. correct code type in addons.markdown
2. add missed code type in crypto.markdown
@silverwind
Copy link
Contributor

LGTM

@silverwind silverwind added the doc Issues and PRs related to the documentations. label Jan 25, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jan 25, 2016

LGTM

1 similar comment
@r-52
Copy link
Contributor

r-52 commented Jan 25, 2016

LGTM

silverwind pushed a commit that referenced this pull request Jan 25, 2016
1. correct code type in addons.markdown
2. add missed code type in crypto.markdown

PR-URL: #4858
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@silverwind
Copy link
Contributor

Thanks! Landed in accd69e.

@silverwind silverwind closed this Jan 25, 2016
rvagg pushed a commit that referenced this pull request Jan 26, 2016
1. correct code type in addons.markdown
2. add missed code type in crypto.markdown

PR-URL: #4858
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
benjamingr pushed a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016
1. correct code type in addons.markdown
2. add missed code type in crypto.markdown

PR-URL: nodejs#4858
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@MylesBorins
Copy link
Contributor

This commit is blocked on being backported until other doc fixes have been backported first

@JacksonTian JacksonTian deleted the doc branch February 18, 2016 06:33
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
1. correct code type in addons.markdown
2. add missed code type in crypto.markdown

PR-URL: #4858
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
1. correct code type in addons.markdown
2. add missed code type in crypto.markdown

PR-URL: #4858
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
1. correct code type in addons.markdown
2. add missed code type in crypto.markdown

PR-URL: #4858
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
1. correct code type in addons.markdown
2. add missed code type in crypto.markdown

PR-URL: nodejs#4858
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants