src: pass syscall on fs.readFileSync fail operation
#48815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Merged
ljharb
approved these changes
Jul 17, 2023
anonrig
force-pushed
the
fix-read-file-sync
branch
from
ce80203 to
606c82a
Compare
|
Should we add a test for this? |
I'm not really sure. The only way to test this outcome is through a carefully written regexp (just like in tape repository). I prefer to add an assertion where |
github-actions
bot
removed
the
request-ci
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
debadree25
approved these changes
Jul 17, 2023
debadree25
added
the
author ready
benjamingr
approved these changes
Jul 17, 2023
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 339eb10 |
juanarbol
pushed a commit
that referenced
this pull request
Jul 17, 2023
PR-URL: #48815 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 6, 2023
PR-URL: nodejs#48815 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 7, 2023
PR-URL: nodejs#48815 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48815 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48815 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes v20.5.0 release.
Ref: #48761 (comment)