Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove ContextEmbedderIndex::kBindingDataStoreIndex #48836

Merged
merged 1 commit into from
Jul 26, 2023
Merged

src: remove ContextEmbedderIndex::kBindingDataStoreIndex #48836

merged 1 commit into from
Jul 26, 2023

Conversation

joyeecheung
Copy link
Member

We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/realm
  • @nodejs/startup
  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 19, 2023
@joyeecheung
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
e1fbe62 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52851/

legendecas
legendecas approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that most call sites of Realm::GetBindingData(context) have a reference to the realm too. The static method can be replaced with an instance method instead in that case.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52854/

@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52865/

This was referenced Jul 21, 2023
Open
Open
Open
Open
@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit faefe56 into nodejs:main Jul 26, 2023
3 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in faefe56

@github-actions github-actions bot mentioned this pull request Jul 27, 2023
Open
18 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@joyeecheung @Ceres6
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
d74d4e9 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.

PR-URL: nodejs#48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@joyeecheung joyeecheung mentioned this pull request Aug 3, 2023
Closed
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@joyeecheung
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
3d265e9 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.

PR-URL: nodejs#48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@joyeecheung
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
7219670 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.

PR-URL: nodejs#48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@joyeecheung @Ceres6
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
0f46758 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.

PR-URL: nodejs#48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@joyeecheung @Ceres6
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
cdea6a8 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.

PR-URL: nodejs#48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@joyeecheung @UlisesGascon
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
02baba0 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.

PR-URL: nodejs#48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@joyeecheung @RafaelGSS
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
3066f69 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.

PR-URL: #48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Aug 16, 2023
@joyeecheung @nodejs-github-bot
src: add per-realm GetBindingData() method
3578bee 
This version avoids the additional access to the embedder slot
when we already have a reference to the realm.

PR-URL: #49007
Refs: #48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs-github-bot pushed a commit that referenced this pull request Aug 16, 2023
@joyeecheung @nodejs-github-bot
src: use per-realm GetBindingData() wherever applicable
6391b3b 
This reduce the number of embedder slot accesses and also removes
the assumption in a few binding methods that the current realm is
the principal realm of the current environment (which is not true
for shadow realms).

PR-URL: #49007
Refs: #48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@joyeecheung @RafaelGSS
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
e0fdb7b 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.

PR-URL: #48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@joyeecheung @UlisesGascon
src: add per-realm GetBindingData() method
184bbdd 
This version avoids the additional access to the embedder slot
when we already have a reference to the realm.

PR-URL: #49007
Refs: #48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@joyeecheung @UlisesGascon
src: use per-realm GetBindingData() wherever applicable
2a35383 
This reduce the number of embedder slot accesses and also removes
the assumption in a few binding methods that the current realm is
the principal realm of the current environment (which is not true
for shadow realms).

PR-URL: #49007
Refs: #48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyeecheung @nodejs-github-bot @legendecas