test: use spawn and spawnPromisified instead of exec
#48991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
atlowChemi
approved these changes
Aug 2, 2023
github-actions
bot
removed
the
request-ci
aduh95
added
the
author ready
aduh95
added
the
commit-queue
29 tasks
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/48991 ✔ Done loading data for nodejs/node/pull/48991 ----------------------------------- PR info ------------------------------------ Title test: use `spawn` and `spawnPromisified` instead of `exec` (#48991) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:spawn-rather-than-exec -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: use `spawn` and `spawnPromisified` instead of `exec` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/48991 Reviewed-By: Chemi Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48991 Reviewed-By: Chemi Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 01 Aug 2023 21:39:09 GMT ✔ Approvals: 1 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/48991#pullrequestreview-1558411880 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-08-02T14:20:51Z: https://ci.nodejs.org/job/node-test-pull-request/53047/ - Querying data for job/node-test-pull-request/53047/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5755923756 |
25 tasks
debadree25
approved these changes
Aug 5, 2023
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a973446 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48991 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48991 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48991 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
PR-URL: #48991 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Merged
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#48991 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
rluvaton
pushed a commit
to rluvaton/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#48991 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 17, 2023
PR-URL: #48991 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important in case the
nodeexecutable path or the CLI args contains some special characters which would be interpreted by the shell.