deps: upgrade v8 to 4.1.0.7 #490
Conversation
|
@bnoordhuis what about https://gist.github.com/domenic/aca7774a5d94156bfcc1? The recommendations I've seen from Google have been uniformly that Node should be tracking Chromium stable when choosing V8 versions. |
|
This is better than the current situation, where 3.31 is not on track for any Chrome release at all.
IMO we should go with 4.1 and then stick with it until Chrome 42 is released. (Maybe during the period after Chrome 41 is released but before 42, we can have some kind of prerelease that allows people to download and test with whatever version of V8 is packaged with Chrome 42 betas.) |
|
@domenic 👍 Sounds good to me. |
|
@domenic Good point, undone in c116a0a (but kept the tests.) |
|
👍 lgtm. Since it's a fix-only release this could land in 1.0.3, right? |
|
I agree with @domenic, so rubber stamp LGTM |
|
I'm unqualified to review this but if @bnoordhuis is happy then lgtm The only thing I ask is for @bnoordhuis to confirm that he believes this to only justify a patch bump and not a minor, that's really all I care about at this stage for my responsibilities. In another thread, the ES6 one I think, @mikeal was proposing something along the lines of tracking Chrome 41 for our own stability cycle. That would give us a nice ~6 week window to put in whatever effort we need to be able to call io.js "stable" and take off the "beta" and "unstable" caveats we put out. It also means our "stable" is V8 "stable" so we can't be criticised of being cowboys with stability. |
|
One comment, otherwise LGTM if tests are passing. |
This commit upgrades V8 from 3.31.74.1 to 4.1.0.7. Despite the major version bump, there are no API or ABI changes, it's a bug fix release only. PR-URL: nodejs#490 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Kenan Sulayman <kenan@sly.mn> Reviewed-By: Rod Vagg <rod@vagg.org>
clang++ on FreeBSD was blaming v8 for using invalid casts from nullptr:
reinterpret_cast from 'nullptr_t' to '...' is not allowed
Replace casts with NULL, or NULL with 0 where applicable.
Fixes: nodejs#324
PR-URL: nodejs#332
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Now that V8 has been upgraded, remove the --noharmony_classes and --noharmony_object_literals workarounds from commits a2751e3 and 4e58211. PR-URL: nodejs#490 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Kenan Sulayman <kenan@sly.mn> Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis
force-pushed
the
upgrade-v8
branch
from
c116a0a to
e8ad773
Compare
|
Landed, thanks everyone. @rvagg Yes, a patch bump is all that is needed. |
|
@bnoordhuis also, anything in here warrant touching |
|
@rvagg No, nothing. Rule of thumb: if nothing changes in deps/v8/include, the release contains no API or ABI changes. |
The 3rd step there is not needed btw, the v8 version is right there in the table. |
This commit upgrades V8 from 3.31.74.1 to 4.1.0.7. Despite the major
version bump, there are no API or ABI changes, it's a bug fix release
only.
R=@indutny, /cc @iojs/tc
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/91/