Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial proposal for additional http2settings #49025

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Initial proposal for additional http2settings #49025

merged 3 commits into from
Dec 18, 2023

Commits on Nov 27, 2023

  1. http2: addtl http/2 settings 

    Currently, node.js http/2 is limited in sending SETTINGs,
that are currently implemented by nghttp2.
However, nghttp2 has the ability to send arbitary SETTINGs,
that are not known beforehand.
This patch adds this feature including a fall back mechanism,
if a SETTING is implemented in a later nghttp2 or node version.

Fixes: nodejs#1337
    @martenrichter
    martenrichter committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2b53b16 View commit details
    Browse the repository at this point in the history

  2. http2: add tests for customSettings 

    Test for the http2 setting's custom settings were added.
    @martenrichter
    martenrichter committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    6bedd4c View commit details
    Browse the repository at this point in the history

  3. http2: customSettings add documentation 

    Add an explanation to the documentation for Http2Settings to explain
the usage of customSettings and its limitations.

Co-authored-by: James M Snell <jasnell@gmail.com>
    @martenrichter @jasnell
    martenrichter and jasnell committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2860c65 View commit details
    Browse the repository at this point in the history