Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x] build, deps, test, tools: avoid excessive LTO, debug information #49064

Closed
wants to merge 3 commits into from
Closed

[v20.x] build, deps, test, tools: avoid excessive LTO, debug information #49064

wants to merge 3 commits into from

Conversation

rockdrilla
Copy link
Contributor

This PR is backport of #49063 for "v20.x" branch.

Signed-off-by: Konstantin Demin rockdrilla@gmail.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Aug 8, 2023
@rockdrilla rockdrilla force-pushed the build-flags-v20.x branch 3 times, most recently from d1c6375 to fb0bef2 Compare August 8, 2023 06:52
@rockdrilla rockdrilla marked this pull request as draft August 8, 2023 09:55
@rockdrilla rockdrilla changed the title [v20.x] build, deps, tools: avoid excessive LTO, PGO, debug information [v20.x] build, deps, tools: avoid excessive LTO, debug information Sep 16, 2023
@rockdrilla
Copy link
Contributor Author

I'd perform more detailed excessive PGO exclusion later (still in progress).

@rockdrilla rockdrilla marked this pull request as ready for review September 16, 2023 19:36
@rockdrilla rockdrilla changed the title [v20.x] build, deps, tools: avoid excessive LTO, debug information [v20.x] build, deps, test, tools: avoid excessive LTO, debug information Sep 16, 2023
@rockdrilla
build, deps, test: avoid excessive LTO
2230927 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@rockdrilla
tools: remove non-working condition
dc4cbc8 
condition doesn't apply to this target type (introduced in 9a4d21d)

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@rockdrilla
build, tools: avoid extra debug information
26269b0 
Don't build intermediate executables with debug information in order
to save some disk space during build.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@targos targos added the blocked PRs that are blocked by other issues or PRs. label Nov 12, 2023
@marco-ippolito
Copy link
Member

marco-ippolito commented Jan 22, 2025 •
edited
Loading

v20 is now in maintainance, I dont think this is going to be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rockdrilla @nodejs-github-bot @marco-ippolito @targos