Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update process.binding deprecation text #49086

Merged
merged 1 commit into from
Aug 11, 2023
Merged

doc: update process.binding deprecation text #49086

merged 1 commit into from
Aug 11, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Aug 9, 2023

As part of the recent security release, 4aa0eff updated the documentation but bd7443a did not.

@tniessen tniessen added security Issues and PRs related to security. deprecations Issues and PRs related to deprecations. labels Aug 9, 2023
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 9, 2023
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2023
@tniessen tniessen added the permission Issues and PRs related to the Permission Model label Aug 10, 2023
@aduh95
Copy link
Contributor

aduh95 commented Aug 10, 2023

@tniessen Can you please rebase to fix the test failure?

@tniessen
doc: update process.binding deprecation text
928a7df 
As part of the recent security release, 4aa0eff updated the
documentation but bd7443a did not.
@tniessen tniessen force-pushed the doc-process-binding-deprecation-pm branch from 9ace315 to 928a7df Compare August 11, 2023 12:37
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit e117f16 into nodejs:main Aug 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in e117f16

martenrichter pushed a commit to martenrichter/node that referenced this pull request Aug 13, 2023
@tniessen @martenrichter
doc: update process.binding deprecation text
46ed309 
As part of the recent security release, 4aa0eff updated the
documentation but bd7443a did not.

PR-URL: nodejs#49086
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@tniessen @Ceres6
doc: update process.binding deprecation text
4feb93b 
As part of the recent security release, 4aa0eff updated the
documentation but bd7443a did not.

PR-URL: nodejs#49086
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@tniessen @Ceres6
doc: update process.binding deprecation text
091289a 
As part of the recent security release, 4aa0eff updated the
documentation but bd7443a did not.

PR-URL: nodejs#49086
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@tniessen @RafaelGSS
doc: update process.binding deprecation text
e6fc6e1 
As part of the recent security release, 4aa0eff updated the
documentation but bd7443a did not.

PR-URL: #49086
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@tniessen @RafaelGSS
doc: update process.binding deprecation text
0463cb3 
As part of the recent security release, 4aa0eff updated the
documentation but bd7443a did not.

PR-URL: nodejs#49086
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@tniessen @rluvaton
doc: update process.binding deprecation text
f0b7a19 
As part of the recent security release, 4aa0eff updated the
documentation but bd7443a did not.

PR-URL: nodejs#49086
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
@tniessen @RafaelGSS
doc: update process.binding deprecation text
d9a7b98 
As part of the recent security release, 4aa0eff updated the
documentation but bd7443a did not.

PR-URL: #49086
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@tniessen @RafaelGSS
doc: update process.binding deprecation text
f888a1d 
As part of the recent security release, 4aa0eff updated the
documentation but bd7443a did not.

PR-URL: #49086
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@MoLow MoLow MoLow approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. permission Issues and PRs related to the Permission Model security Issues and PRs related to security.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @aduh95 @nodejs-github-bot @benjamingr @lpinca @MoLow @atlowChemi @targos