bootstrap: only use the isolate snapshot when compiling code cache #49288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not actually need to deserialize the context and the whole environment to compile the code cache, since code cache are not context-dependent anyway, deserializing just the isolate snapshot is enough.
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
27 tasks
legendecas
approved these changes
Aug 23, 2023
This was referenced Aug 24, 2023
github-actions
bot
removed
the
request-ci
joyeecheung
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49288 ✔ Done loading data for nodejs/node/pull/49288 ----------------------------------- PR info ------------------------------------ Title bootstrap: only use the isolate snapshot when compiling code cache (#49288) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:isolate-code-cache -> nodejs:main Labels c++, needs-ci Commits 1 - bootstrap: only use the isolate snapshot when compiling code cache Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/49288 Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49288 Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 22 Aug 2023 17:28:31 GMT ✔ Approvals: 1 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/49288#pullrequestreview-1590612969 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-08-30T21:57:54Z: https://ci.nodejs.org/job/node-test-pull-request/53653/ - Querying data for job/node-test-pull-request/53653/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6035126866 |
joyeecheung
added
request-ci
github-actions
bot
removed
the
request-ci
22 tasks
This was referenced Sep 3, 2023
joyeecheung
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49288 ✔ Done loading data for nodejs/node/pull/49288 ----------------------------------- PR info ------------------------------------ Title bootstrap: only use the isolate snapshot when compiling code cache (#49288) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:isolate-code-cache -> nodejs:main Labels c++, needs-ci Commits 1 - bootstrap: only use the isolate snapshot when compiling code cache Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/49288 Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49288 Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 22 Aug 2023 17:28:31 GMT ✔ Approvals: 1 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/49288#pullrequestreview-1590612969 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-09-02T20:14:04Z: https://ci.nodejs.org/job/node-test-pull-request/53696/ - Querying data for job/node-test-pull-request/53696/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6075654085 |
joyeecheung
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49288 ✔ Done loading data for nodejs/node/pull/49288 ----------------------------------- PR info ------------------------------------ Title bootstrap: only use the isolate snapshot when compiling code cache (#49288) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:isolate-code-cache -> nodejs:main Labels c++, needs-ci Commits 1 - bootstrap: only use the isolate snapshot when compiling code cache Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/49288 Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49288 Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 22 Aug 2023 17:28:31 GMT ✔ Approvals: 1 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/49288#pullrequestreview-1590612969 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-09-04T16:08:03Z: https://ci.nodejs.org/job/node-test-pull-request/53696/ - Querying data for job/node-test-pull-request/53696/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6077625182 |
|
Somehow the GitHub UI says "All checks have passed" and node-core-utils still complains about it...perhaps something is wrong the the GitHub API result, landing it manually. |
joyeecheung
added a commit
that referenced
this pull request
Sep 4, 2023
We do not actually need to deserialize the context and the whole environment to compile the code cache, since code cache are not context-dependent anyway, deserializing just the isolate snapshot is enough. PR-URL: #49288 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
|
Landed in 4d0f930 |
This was referenced Sep 5, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
We do not actually need to deserialize the context and the whole environment to compile the code cache, since code cache are not context-dependent anyway, deserializing just the isolate snapshot is enough. PR-URL: #49288 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
We do not actually need to deserialize the context and the whole environment to compile the code cache, since code cache are not context-dependent anyway, deserializing just the isolate snapshot is enough. PR-URL: nodejs#49288 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not actually need to deserialize the context and the whole environment to compile the code cache, since code cache are not context-dependent anyway, deserializing just the isolate snapshot is enough.