Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: scope redeclared vars in test-child-process* #4944

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 29, 2016

A handful of child process tests had variables declared multiple times
in the same scope using var. This change scopes those declarations.

A handful of child process tests had variables declared multiple times
in the same scope using `var`. This change scopes those declarations.
@Trott Trott added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. labels Jan 29, 2016
@Trott
Copy link
Member Author

Trott commented Jan 29, 2016

@jasnell
Copy link
Member

jasnell commented Jan 29, 2016

lts watch label applied. Hey @Trott , can I ask you to please attach the lts-watch label to these kinds of test updates? It would save a ton of time :-)

@@ -42,7 +42,7 @@ if (process.argv[2] === 'child') {
});

} else {
var server = dgram.createSocket('udp4');
server = dgram.createSocket('udp4');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you declare the variable outside of the if block ?
Edit: I mean move the declaration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done!

@targos
Copy link
Member

targos commented Jan 29, 2016

LGTM with a comment.

Trott added a commit to Trott/io.js that referenced this pull request Feb 1, 2016
A handful of child process tests had variables declared multiple times
in the same scope using `var`. This change scopes those declarations.

PR-URL: nodejs#4944
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@Trott
Copy link
Member Author

Trott commented Feb 1, 2016

Landed in 185f849

@Trott Trott closed this Feb 1, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
A handful of child process tests had variables declared multiple times
in the same scope using `var`. This change scopes those declarations.

PR-URL: #4944
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
A handful of child process tests had variables declared multiple times
in the same scope using `var`. This change scopes those declarations.

PR-URL: #4944
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
A handful of child process tests had variables declared multiple times
in the same scope using `var`. This change scopes those declarations.

PR-URL: #4944
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
A handful of child process tests had variables declared multiple times
in the same scope using `var`. This change scopes those declarations.

PR-URL: #4944
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
A handful of child process tests had variables declared multiple times
in the same scope using `var`. This change scopes those declarations.

PR-URL: nodejs#4944
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@Trott Trott deleted the test-child-process-no-redeclare branch January 13, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants