doc: fix documentation for input option in child_process methods [execFile, execFileSync, spawnSync] #49481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
ariel-weiss
force-pushed
the
doc-spawnsync-input
branch
from
c1e0f97 to
c551149
Compare
|
@nodejs/child_process |
benjamingr
approved these changes
Sep 6, 2023
aymen94
approved these changes
Sep 6, 2023
atlowChemi
approved these changes
Sep 6, 2023
atlowChemi
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6b135a1 |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49481 Fixes: nodejs#49417 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the documentation for the
inputoption in child_process file, at execFile, execFileSync, spawnSync functions.This update now clarify that supplying value to the
inputoption will overridestdio[0], only ifstdio[0]is set to'pipe'.This will help avoid confusion when using the
inputoption in any of the functions above.Also updated the default value for the
stdiooption in the docs for the child_process.spawnSync function, to complete the picture.Fixes: #49417